Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Issue 988703002: Revert of Revert of Simplify and compact transitions storage (Closed)

Created:
5 years, 9 months ago by Jakob Kummerow
Modified:
5 years, 9 months ago
Reviewers:
ulan, Toon Verwaest
CC:
v8-dev, ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland: Simplify and compact transitions storage Original issue: https://codereview.chromium.org/980573002/ Simple transitions are now stored in a map's "transitions" field (as a WeakCell wrapping the target map); full TransitionArrays are used when that's not sufficient. To encapsulate these storage format implementation details, functions for manipulating and querying transitions have been refactored to be static functions on the TransitionArray class, and take maps as inputs. Committed: https://crrev.com/233ea0eef8510063ea8a27a2b8261b23bdd78a6b Cr-Commit-Position: refs/heads/master@{#27044}

Patch Set 1 : revert of revert #

Patch Set 2 : rebased #

Patch Set 3 : fix: replaced TransitionArrays must be zapped #

Patch Set 4 : fix extra ';', again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+967 lines, -985 lines) Patch
M src/heap-snapshot-generator.cc View 1 1 chunk +16 lines, -13 lines 0 comments Download
M src/heap/heap.cc View 1 6 chunks +6 lines, -6 lines 0 comments Download
M src/heap/mark-compact.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/heap/mark-compact.cc View 1 8 chunks +44 lines, -24 lines 0 comments Download
M src/heap/objects-visiting-inl.h View 1 2 chunks +10 lines, -17 lines 0 comments Download
M src/hydrogen.h View 1 1 chunk +4 lines, -3 lines 0 comments Download
M src/json-parser.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M src/objects.h View 1 2 8 chunks +11 lines, -83 lines 0 comments Download
M src/objects.cc View 1 27 chunks +95 lines, -197 lines 0 comments Download
M src/objects-debug.cc View 1 3 chunks +19 lines, -8 lines 0 comments Download
M src/objects-inl.h View 1 2 3 6 chunks +9 lines, -170 lines 0 comments Download
M src/objects-printer.cc View 1 5 chunks +20 lines, -16 lines 0 comments Download
M src/transitions.h View 1 4 chunks +174 lines, -123 lines 0 comments Download
M src/transitions.cc View 1 2 3 chunks +405 lines, -116 lines 0 comments Download
M src/transitions-inl.h View 1 3 chunks +26 lines, -91 lines 0 comments Download
M test/cctest/test-heap.cc View 1 6 chunks +15 lines, -8 lines 0 comments Download
M test/cctest/test-migrations.cc View 1 3 chunks +10 lines, -8 lines 0 comments Download
M test/cctest/test-transitions.cc View 1 10 chunks +99 lines, -98 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
Jakob Kummerow
Created Revert of Revert of Simplify and compact transitions storage
5 years, 9 months ago (2015-03-06 12:33:49 UTC) #1
Jakob Kummerow
PTAL. Patch set 2 is the rebased version of the original commit. Patch set 3 ...
5 years, 9 months ago (2015-03-06 12:46:03 UTC) #2
Toon Verwaest
lgtm
5 years, 9 months ago (2015-03-06 13:23:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988703002/30004
5 years, 9 months ago (2015-03-06 13:24:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988703002/270001
5 years, 9 months ago (2015-03-06 13:39:16 UTC) #8
Michael Achenbach
FYI: CL description and subject are different. But never mind - I guess the CL ...
5 years, 9 months ago (2015-03-06 13:52:48 UTC) #9
Jakob Kummerow
On 2015/03/06 13:52:48, Michael Achenbach wrote: > FYI: CL description and subject are different. But ...
5 years, 9 months ago (2015-03-06 13:53:59 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:270001)
5 years, 9 months ago (2015-03-06 14:08:39 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 14:09:01 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/233ea0eef8510063ea8a27a2b8261b23bdd78a6b
Cr-Commit-Position: refs/heads/master@{#27044}

Powered by Google App Engine
This is Rietveld 408576698