base/trace_event/memory_dump_provider.h - Issue 988693005: Chromium roll (https://codereview.chromium.org/976353002)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/memory_dump_provider.h

Issue 988693005: Chromium roll (https://codereview.chromium.org/976353002) (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: fixed bad android build patch Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/memory_dump_provider.h

diff --git a/base/trace_event/memory_dump_provider.h b/base/trace_event/memory_dump_provider.h

index 18363c5928bc2e6fcc11a03d65ddf83e60966566..1c5bbb15050fc5eeb31e92fab34afe12dc8342b8 100644

--- a/base/trace_event/memory_dump_provider.h

+++ b/base/trace_event/memory_dump_provider.h

@@ -17,7 +17,10 @@ class ProcessMemoryDump;

class BASE_EXPORT MemoryDumpProvider {

public:

// Called by the MemoryDumpManager when generating dump points.

- virtual void DumpInto(ProcessMemoryDump* pmd) = 0;

+ // Returns: true if the |pmd| was successfully populated, false otherwise.

+ virtual bool DumpInto(ProcessMemoryDump* pmd) = 0;

+ virtual const char* GetFriendlyName() const = 0;

protected:

MemoryDumpProvider() {}