shell/launcher_main.cc - Issue 988693005: Chromium roll (https://codereview.chromium.org/976353002)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: shell/launcher_main.cc

Issue 988693005: Chromium roll (https://codereview.chromium.org/976353002) (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: fixed bad android build patch Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: shell/launcher_main.cc

diff --git a/shell/launcher_main.cc b/shell/launcher_main.cc

index 410417bd82f9f0c5ba5204efc5896919a27af0f1..4a95d5350656f55f623e3816038104b84a90463a 100644

--- a/shell/launcher_main.cc

+++ b/shell/launcher_main.cc

@@ -46,7 +46,7 @@ class Launcher : public embedder::ProcessDelegate {

&app_args_);

}

- ~Launcher() {

+ ~Launcher() override {

// TODO(vtl): We need to destroy this before calling

// ShutdownIPCSupportOnIOThread(). This is all quite sketchy, and we really

// should convert all of this to running the application on the main thread,

« no previous file with comments | « shell/application_manager/application_manager.h ('k') | shell/test/pingable_app.cc » ('j') | no next file with comments »