Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Side by Side Diff: testing/scripts/webkit_python_tests.py

Issue 988693005: Chromium roll (https://codereview.chromium.org/976353002) (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: fixed bad android build patch Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « testing/scripts/webkit_lint.py ('k') | third_party/ashmem/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2015 The Chromium Authors. All rights reserved. 2 # Copyright 2015 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 import json 6 import json
7 import os 7 import os
8 import sys 8 import sys
9 9
10 10
11 import common 11 import common
12 12
13 13
14 def main_run(args): 14 def main_run(args):
15 with common.temporary_file() as tempfile_path: 15 with common.temporary_file() as tempfile_path:
16 rc = common.run_command([ 16 rc = common.run_command([
17 os.path.join(common.SRC_DIR, 'android_webview', 'tools', 17 sys.executable,
18 'webview_licenses.py'), 18 os.path.join(common.SRC_DIR, 'third_party', 'WebKit',
19 'scan', 19 'Tools', 'Scripts', 'test-webkitpy'),
20 '--json', tempfile_path 20 '--write-full-results-to', tempfile_path,
21 ]) 21 ])
22 22
23 with open(tempfile_path) as f: 23 with open(tempfile_path) as f:
24 results = json.load(f) 24 results = json.load(f)
25 25
26 parsed_results = common.parse_common_test_results(results)
27 failures = parsed_results['unexpected_failures']
28
26 json.dump({ 29 json.dump({
27 'valid': True, 30 'valid': bool(rc <= common.MAX_FAILURES_EXIT_STATUS and
28 'failures': results, 31 ((rc == 0) or failures)),
32 'failures': failures.keys(),
29 }, args.output) 33 }, args.output)
30 34
31 return rc 35 return rc
32 36
33 37
34 def main_compile_targets(args): 38 def main_compile_targets(args):
35 json.dump([], args.output) 39 json.dump([], args.output)
36 40
37 41
38 if __name__ == '__main__': 42 if __name__ == '__main__':
39 funcs = { 43 funcs = {
40 'run': main_run, 44 'run': main_run,
41 'compile_targets': main_compile_targets, 45 'compile_targets': main_compile_targets,
42 } 46 }
43 sys.exit(common.run_script(sys.argv[1:], funcs)) 47 sys.exit(common.run_script(sys.argv[1:], funcs))
OLDNEW
« no previous file with comments | « testing/scripts/webkit_lint.py ('k') | third_party/ashmem/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698