| OLD | NEW | 
|---|
| 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. | 
| 2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be | 
| 3 # found in the LICENSE file. | 3 # found in the LICENSE file. | 
| 4 | 4 | 
| 5 import("clang.gni") | 5 import("clang.gni") | 
| 6 | 6 | 
| 7 config("find_bad_constructs") { | 7 config("find_bad_constructs") { | 
| 8   if (clang_use_chrome_plugins) { | 8   if (clang_use_chrome_plugins) { | 
| 9     cflags = [ | 9     cflags = [ | 
| 10       "-Xclang", | 10       "-Xclang", | 
| 11       "-load", | 11       "-load", | 
| 12       "-Xclang", | 12       "-Xclang", | 
| 13     ] | 13     ] | 
| 14 | 14 | 
| 15     if (is_mac || is_ios) { | 15     if (is_mac || is_ios) { | 
| 16       cflags += [ rebase_path( | 16       cflags += [ rebase_path( | 
| 17               "//third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs
    .dylib", | 17               "//third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs
    .dylib", | 
| 18               root_build_dir) ] | 18               root_build_dir) ] | 
| 19     } else if (is_linux) { | 19     } else if (is_linux) { | 
| 20       cflags += [ rebase_path( | 20       cflags += [ rebase_path( | 
| 21               "//third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs
    .so", | 21               "//third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs
    .so", | 
| 22               root_build_dir) ] | 22               root_build_dir) ] | 
| 23     } | 23     } | 
| 24 |  | 
| 25     cflags += [ |  | 
| 26       "-Xclang", |  | 
| 27       "-add-plugin", |  | 
| 28       "-Xclang", |  | 
| 29       "find-bad-constructs", |  | 
| 30     ] |  | 
| 31   } | 24   } | 
| 32 } | 25 } | 
| 33 | 26 | 
| 34 # Enables some extra Clang-specific warnings. Some third-party code won't | 27 # Enables some extra Clang-specific warnings. Some third-party code won't | 
| 35 # compile with these so may want to remove this config. | 28 # compile with these so may want to remove this config. | 
| 36 config("extra_warnings") { | 29 config("extra_warnings") { | 
| 37   cflags = [ | 30   cflags = [ | 
| 38     "-Wheader-hygiene", | 31     "-Wheader-hygiene", | 
| 39 | 32 | 
| 40     # Warns when a const char[] is converted to bool. | 33     # Warns when a const char[] is converted to bool. | 
| 41     "-Wstring-conversion", | 34     "-Wstring-conversion", | 
| 42   ] | 35   ] | 
| 43 } | 36 } | 
| OLD | NEW | 
|---|