Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: build/android/lint/suppressions.xml

Issue 988693005: Chromium roll (https://codereview.chromium.org/976353002) (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: fixed bad android build patch Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/lint/OWNERS ('k') | build/android/provision_devices.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <?xml version="1.0" encoding="utf-8"?> 1 <?xml version="1.0" encoding="utf-8"?>
2 <lint> 2 <lint>
3 <!-- 3 <!--
4 STOP! It looks like you want to suppress some lint errors: 4 STOP! It looks like you want to suppress some lint errors:
5 - Have you tried identifing the offending patch? 5 - Have you tried identifing the offending patch?
6 Ask the author for a fix and/or revert the patch. 6 Ask the author for a fix and/or revert the patch.
7 - It is preferred to add suppressions in the code instead of 7 - It is preferred to add suppressions in the code instead of
8 sweeping it under the rug here. See: 8 sweeping it under the rug here. See:
9 9
10 http://developer.android.com/tools/debugging/improving-w-lint.html 10 http://developer.android.com/tools/debugging/improving-w-lint.html
(...skipping 25 matching lines...) Expand all
36 <ignore path="content/public/android/java/src/org/chromium/content/browser/P opupZoomer.java"/> 36 <ignore path="content/public/android/java/src/org/chromium/content/browser/P opupZoomer.java"/>
37 </issue> 37 </issue>
38 <issue id="ExportedContentProvider"> 38 <issue id="ExportedContentProvider">
39 <ignore path="AndroidManifest.xml"/> 39 <ignore path="AndroidManifest.xml"/>
40 </issue> 40 </issue>
41 <issue id="HandlerLeak"> 41 <issue id="HandlerLeak">
42 <ignore path="remoting/android/java/src/org/chromium/chromoting/TapGestureDe tector.java"/> 42 <ignore path="remoting/android/java/src/org/chromium/chromoting/TapGestureDe tector.java"/>
43 </issue> 43 </issue>
44 <issue id="IconDensities"> 44 <issue id="IconDensities">
45 <!-- crbug.com/457918 is tracking missing assets --> 45 <!-- crbug.com/457918 is tracking missing assets -->
46 <ignore path="components/web_contents_delegate_android/android/java/res/draw able-xxhdpi"/>
47 <ignore path="components/web_contents_delegate_android/android/java/res/draw able-xxxhdpi"/>
46 <ignore path="content/public/android/java/res/drawable-xxhdpi"/> 48 <ignore path="content/public/android/java/res/drawable-xxhdpi"/>
47 <ignore path="content/public/android/java/res/drawable-xxxhdpi"/> 49 <ignore path="content/public/android/java/res/drawable-xxxhdpi"/>
48 <ignore path="chrome/android/java/res/drawable-xxhdpi"/> 50 <ignore path="chrome/android/java/res/drawable-xxhdpi"/>
49 <ignore path="chrome/android/java/res/drawable-xxxhdpi"/> 51 <ignore path="chrome/android/java/res/drawable-xxxhdpi"/>
50 <ignore path="ui/android/java/res/drawable-xxhdpi"/> 52 <ignore path="ui/android/java/res/drawable-xxhdpi"/>
51 <ignore path="ui/android/java/res/drawable-xxxhdpi"/> 53 <ignore path="ui/android/java/res/drawable-xxxhdpi"/>
52 </issue> 54 </issue>
53 <!-- It is OK for content_shell_apk and chrome_shell_apk to have missing asset s. --> 55 <!-- It is OK for content_shell_apk and chrome_shell_apk to have missing asset s. -->
54 <issue id="IconLocation"> 56 <issue id="IconLocation">
55 <ignore path="content/shell/android/java/res/"/> 57 <ignore path="content/shell/android/java/res/"/>
56 <ignore path="chrome/android/shell/res/"/> 58 <ignore path="chrome/android/shell/res/"/>
57 </issue> 59 </issue>
58 <issue id="InconsistentLayout" severity="ignore"/> 60 <issue id="InconsistentLayout" severity="ignore"/>
59 <issue id="InflateParams" severity="ignore"/> 61 <issue id="InflateParams" severity="ignore"/>
60 <issue id="MissingApplicationIcon" severity="ignore"/> 62 <issue id="MissingApplicationIcon" severity="ignore"/>
61 <issue id="MissingRegistered" severity="ignore"/> 63 <issue id="MissingRegistered" severity="ignore"/>
62 <issue id="MissingVersion"> 64 <issue id="MissingVersion">
63 <ignore path="AndroidManifest.xml"/> 65 <ignore path="AndroidManifest.xml"/>
64 </issue> 66 </issue>
65 <!-- Disabling is InlinedApi and NewApi is bad but we have too many of these e rrors and nobody is fixing it. crbug.com/411461 -->
66 <issue id="InlinedApi" severity="ignore"/> 67 <issue id="InlinedApi" severity="ignore"/>
67 <issue id="NewApi" severity="ignore"/> 68 <issue id="NewApi">
69 <ignore regexp="Attribute `paddingStart` referenced here can result in a cra sh on some specific devices older than API 17"/>
70 <ignore path="org/chromium/base/AnimationFrameTimeHistogram$Recorder.class"/ >
71 <ignore path="org/chromium/base/JavaHandlerThread.class"/>
72 <ignore path="org/chromium/base/SysUtils.class"/>
73 <ignore path="org/chromium/chrome/browser/preferences/website/AddExceptionPr eference.class"/>
74 <ignore path="org/chromium/chrome/browser/infobar/AnimationHelper$*.class"/>
75 <ignore path="org/chromium/chrome/browser/infobar/AppBannerInfoBar.class"/>
76 <ignore path="org/chromium/chrome/browser/BookmarkUtils.class"/>
77 <ignore path="org/chromium/chrome/browser/widget/ButtonCompat.class"/>
78 <ignore path="org/chromium/chrome/browser/autofill/CardUnmaskPrompt.class"/>
79 <ignore path="org/chromium/chrome/browser/LollipopTtsPlatformImpl.class"/>
80 <ignore path="org/chromium/chrome/browser/LollipopTtsPlatformImpl$*.class"/>
81 <ignore path="org/chromium/chrome/browser/TtsPlatformImpl.class"/>
82 <ignore path="org/chromium/chrome/browser/TtsPlatformImpl$*.class"/>
83 <ignore path="org/chromium/content/browser/accessibility/BrowserAccessibilit yManager.class"/>
84 <ignore path="org/chromium/content/browser/ContentViewCore.class"/>
85 <ignore path="org/chromium/content/browser/accessibility/JellyBeanAccessibil ityInjector.class"/>
86 <ignore path="org/chromium/content/browser/accessibility/JellyBeanBrowserAcc essibilityManager$*.class"/>
87 <ignore path="org/chromium/content/browser/accessibility/LollipopAccessibili tyInjector.class"/>
88 <ignore path="org/chromium/content/browser/accessibility/LollipopAccessibili tyInjector$*.class"/>
89 <ignore path="org/chromium/content/browser/accessibility/LollipopBrowserAcce ssibilityManager.class"/>
90 <ignore path="org/chromium/media/AudioManagerAndroid.class"/>
91 <ignore path="org/chromium/media/MediaCodecBridge.class"/>
92 <ignore path="org/chromium/media/MediaDrmBridge.class"/>
93 <ignore path="org/chromium/media/MediaDrmBridge$*.class"/>
94 <ignore path="org/chromium/media/VideoCaptureCamera.class"/>
95 <ignore path="org/chromium/media/VideoCaptureCamera2.class"/>
96 <ignore path="org/chromium/media/VideoCaptureCamera2$*.class"/>
97 <ignore path="org/chromium/media/WebAudioMediaCodecBridge.class"/>
98 <ignore path="org/chromium/printing/PrintDocumentAdapterWrapper.class"/>
99 <ignore path="org/chromium/printing/PrintManagerDelegateImpl.class"/>
100 <ignore path="org/chromium/printing/PrintingControllerImpl.class"/>
101 <ignore path="org/chromium/ui/base/Clipboard.class"/>
102 <ignore path="org/chromium/ui/ColorPickerAdvancedComponent.class"/>
103 <ignore path="org/chromium/ui/gfx/DeviceDisplayInfo.class"/>
104 <ignore path="org/chromium/ui/gl/SurfaceTexturePlatformWrapper.class"/>
105 <ignore path="org/chromium/ui/widget/TextViewWithClickableSpans.class"/>
106 <ignore path="org/chromium/ui/picker/TwoFieldDatePicker.class"/>
107 </issue>
68 <issue id="OldTargetApi"> 108 <issue id="OldTargetApi">
69 <ignore path="AndroidManifest.xml"/> 109 <ignore path="AndroidManifest.xml"/>
70 </issue> 110 </issue>
71 <issue id="Overdraw" severity="ignore"/> 111 <issue id="Overdraw" severity="ignore"/>
72 <issue id="Recycle" severity="ignore"/> 112 <issue id="Recycle" severity="ignore"/>
73 <issue id="Registered" severity="ignore"/> 113 <issue id="Registered" severity="ignore"/>
74 <issue id="RtlCompat" severity="ignore"/> 114 <issue id="RtlCompat" severity="ignore"/>
75 <issue id="RtlEnabled" severity="ignore"/> 115 <issue id="RtlEnabled" severity="ignore"/>
76 <issue id="RtlSymmetry" severity="ignore"/> 116 <issue id="RtlSymmetry" severity="ignore"/>
77 <issue id="SdCardPath"> 117 <issue id="SdCardPath">
78 <ignore path="content/public/android/java/src/org/chromium/content/browser/M ediaResourceGetter.java"/> 118 <ignore path="content/public/android/java/src/org/chromium/content/browser/M ediaResourceGetter.java"/>
79 </issue> 119 </issue>
80 <issue id="SetJavaScriptEnabled" severity="ignore"/> 120 <issue id="SetJavaScriptEnabled" severity="ignore"/>
81 <issue id="UnusedResources"> 121 <issue id="UnusedResources">
82 <!-- TODO(aurimas): remove suppression once crbug.com/458328 is fixed. -->
83 <ignore path="content/public/android/java/res/layout/validation_message_bubb le.xml" />
84
85 <!-- These files are used by chrome_shell_apk and chrome_apk targets. --> 122 <!-- These files are used by chrome_shell_apk and chrome_apk targets. -->
86 <ignore path="chrome/android/java/res/layout/accessibility_tab_switcher.xml" /> 123 <ignore path="chrome/android/java/res/layout/accessibility_tab_switcher.xml" />
87 <ignore path="chrome/android/java/res/drawable/btn_back.xml" /> 124 <ignore path="chrome/android/java/res/drawable/btn_back.xml" />
88 <ignore path="chrome/android/java/res/drawable/btn_forward.xml" /> 125 <ignore path="chrome/android/java/res/drawable/btn_forward.xml" />
89 </issue> 126 </issue>
90 <issue id="SignatureOrSystemPermissions" severity="ignore"/> 127 <issue id="SignatureOrSystemPermissions" severity="ignore"/>
91 <issue id="UnusedAttribute" severity="ignore"/> 128 <issue id="UnusedAttribute" severity="ignore"/>
92 <issue id="ViewConstructor" severity="ignore"/> 129 <issue id="ViewConstructor" severity="ignore"/>
93 <issue id="WrongCall" severity="ignore"/> 130 <issue id="WrongCall" severity="ignore"/>
94 </lint> 131 </lint>
OLDNEW
« no previous file with comments | « build/android/lint/OWNERS ('k') | build/android/provision_devices.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698