Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Issue 988693004: MSan: check data is initialized when serializing with base::Pickle. (Closed)

Created:
5 years, 9 months ago by earthdok
Modified:
5 years, 9 months ago
Reviewers:
Lei Zhang, Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MSan: check data is initialized when serializing with base::Pickle. Serialization implies that the data is going to leave the process one way or another, and it's never a good idea to leak uninitialized bytes. In most cases MSan would catch this later on (e.g. on a write()). There are exceptions to that, however, such as writing to shared memory. It doesn't hurt to have an extra check here. BUG=463906 R=thakis@chromium.org Committed: https://crrev.com/2c705b038413d30d7aae5ff5d09882575e93c898 Cr-Commit-Position: refs/heads/master@{#319459}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M base/compiler_specific.h View 1 chunk +10 lines, -2 lines 0 comments Download
M base/pickle.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
earthdok
5 years, 9 months ago (2015-03-06 14:52:27 UTC) #1
Nico
lgtm
5 years, 9 months ago (2015-03-06 15:43:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988693004/1
5 years, 9 months ago (2015-03-06 15:43:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-06 17:10:08 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/2c705b038413d30d7aae5ff5d09882575e93c898 Cr-Commit-Position: refs/heads/master@{#319459}
5 years, 9 months ago (2015-03-06 17:10:50 UTC) #6
Lei Zhang
This is failing. I'll file bugs for the failures and revert this for now. http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/4348
5 years, 9 months ago (2015-03-06 21:32:06 UTC) #8
Lei Zhang
5 years, 9 months ago (2015-03-06 21:34:01 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/985893002/ by thestig@chromium.org.

The reason for reverting is: Found errors w.r.t. IPC messages. Reverting for now
while people fix the errors..

Powered by Google App Engine
This is Rietveld 408576698