Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 988693003: Store the next serial number in the function cache rather than in the isolate.Don't overwrite existi (Closed)

Created:
5 years, 9 months ago by Toon Verwaest
Modified:
5 years, 9 months ago
Reviewers:
dcarney, Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Don't overwrite existing serial numbers on the function template, otherwise instantiating the function for a new context causes the serial number to bump. Committed: https://crrev.com/1e638c3610ec6938e5fb16c42018642195782fb2 Cr-Commit-Position: refs/heads/master@{#27048}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/api.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
Toon Verwaest
PTAL
5 years, 9 months ago (2015-03-06 14:24:30 UTC) #2
Yang
On 2015/03/06 14:24:30, Toon Verwaest wrote: > PTAL lgtm.
5 years, 9 months ago (2015-03-06 15:01:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988693003/60001
5 years, 9 months ago (2015-03-06 15:03:16 UTC) #6
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-06 15:25:56 UTC) #7
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/1e638c3610ec6938e5fb16c42018642195782fb2 Cr-Commit-Position: refs/heads/master@{#27048}
5 years, 9 months ago (2015-03-06 15:26:08 UTC) #8
Toon Verwaest
5 years, 9 months ago (2015-03-09 10:53:29 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/993533003/ by verwaest@chromium.org.

The reason for reverting is: This doesn't do what it's supposed to do. The
problem seems to lie on the blink side, people aren't reusing their
FunctionTemplates (or creating them when not necessary)..

Powered by Google App Engine
This is Rietveld 408576698