Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: src/objects.h

Issue 988653003: Use platform specific stubs for vector-based Load/KeyedLoad. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: slot_count = FLAG_vector_ics ? 2 : 1. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 8ddcd8b04fc7a8d0cf4171f598cf2ba50ecfc65f..e3560df1e4f26248eaa4b3480021258d0c61e1be 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -8782,11 +8782,11 @@ class Name: public HeapObject {
// ES6 symbols.
class Symbol: public Name {
public:
- // [name]: the print name of a symbol, or undefined if none.
- DECL_ACCESSORS(name, Object)
-
DECL_ACCESSORS(flags, Smi)
+ // [name]: the print name of a symbol, or undefined if none
+ DECL_ACCESSORS(name, Object)
+
// [is_private]: whether this is a private symbol.
DECL_BOOLEAN_ACCESSORS(is_private)
@@ -8801,11 +8801,12 @@ class Symbol: public Name {
DECLARE_VERIFIER(Symbol)
// Layout description.
- static const int kNameOffset = Name::kSize;
- static const int kFlagsOffset = kNameOffset + kPointerSize;
- static const int kSize = kFlagsOffset + kPointerSize;
+ static const int kFlagsOffset = Name::kSize;
Toon Verwaest 2015/03/11 17:55:02 Is this still necessary? [At this point haven't lo
mvstanton 2015/03/12 17:05:34 Yes, I still want to do something in here but I'll
+ static const int kNameOffset = kFlagsOffset + kPointerSize;
+ static const int kSize = kNameOffset + kPointerSize;
- typedef FixedBodyDescriptor<kNameOffset, kFlagsOffset, kSize> BodyDescriptor;
+ typedef FixedBodyDescriptor<kFlagsOffset, kNameOffset + kPointerSize, kSize>
+ BodyDescriptor;
void SymbolShortPrint(std::ostream& os);

Powered by Google App Engine
This is Rietveld 408576698