Issue 988653002: Fix unused variable pylint warning.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 988653002: Fix unused variable pylint warning. (Closed)

Created:
5 years, 9 months ago by qsr

Modified:
5 years, 9 months ago

Reviewers:
ppi

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix unused variable pylint warning. R=ppi@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/07f4119fa86c928cdfb75ca7c1c734a0873300af

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+11 lines, -5 lines)			Patch
M	examples/python/__mojo__.py	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	mojo/public/python/mojo_application/application_delegate.py	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	mojo/public/python/mojo_application/application_impl.py	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ppi

Pardon curiosity, but what's the warning? Is it about unused method parameters? If so, why ...

5 years, 9 months ago (2015-03-06 09:56:31 UTC) #2

ppi

Thanks for the explanation off-bug, lgtm. Nit: say "Fix unused variable pylint warning" in the ...

5 years, 9 months ago (2015-03-06 10:06:17 UTC) #3

qsr

5 years, 9 months ago (2015-03-06 10:09:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
07f4119fa86c928cdfb75ca7c1c734a0873300af (presubmit successful).

Expand Messages | Collapse Messages