Linux: Enable ODR violation detection. (try 2)

third_party/libphonenumber/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//testing/test.gni")
 import("//third_party/protobuf/proto_library.gni")
 
 proto_library("proto") {
   sources = [
     "src/resources/phonemetadata.proto",
@@ skipping 27 matching lines @@
     "src/phonenumbers/regexp_adapter_icu.cc",
     "src/phonenumbers/regexp_cache.cc",
     "src/phonenumbers/string_byte_sink.cc",
     "src/phonenumbers/stringutil.cc",
     "src/phonenumbers/unicodestring.cc",
     "src/phonenumbers/utf/rune.c",
     "src/phonenumbers/utf/unicodetext.cc",
     "src/phonenumbers/utf/unilib.cc",
   ]
 
-  # TODO(scottmg): Temporary until https://codereview.appspot.com/134650043/
-  # lands and rolls. http://crbug.com/335824
+  # libphonenumber's base/logging.h is a minimal implementation where DCHECKs
+  # do not consume their arguments. This leads to unused variable warnings in
+  # release builds.
   configs -= [ "//build/config/compiler:chromium_code" ]
   configs += [ "//build/config/compiler:no_chromium_code" ]
 
   public_configs = [ ":libphonenumber_config" ]
 
   public_deps = [
     ":proto",
   ]
   deps = [
     ":proto",
@@ skipping 36 matching lines @@
   deps = [
     ":libphonenumber_without_metadata",
     "//base",
     "//base/test:run_all_unittests",
     "//base/third_party/dynamic_annotations",
     "//third_party/icu",
     "//testing/gmock",
     "//testing/gtest",
   ]
 }