extensions/renderer/user_script_injector.h - Issue 988633003: Refactoring: de-couple Extensions from "script injection System" [render side]:4

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/user_script_injector.h

Issue 988633003: Refactoring: de-couple Extensions from "script injection System" [render side]:4 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/common/extension_set.h ('K') | « extensions/renderer/script_injection_manager.cc ('k') | extensions/renderer/user_script_injector.cc » ('j') | extensions/renderer/user_script_set_manager.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/user_script_injector.h

diff --git a/extensions/renderer/user_script_injector.h b/extensions/renderer/user_script_injector.h

index c028b2dc3205d543db094e451830cfb968c9a74b..748fa297ea9dc94a5d0a9023d95d3db0679147bd 100644

--- a/extensions/renderer/user_script_injector.h

+++ b/extensions/renderer/user_script_injector.h

@@ -32,7 +32,7 @@ class UserScriptInjector : public ScriptInjector,

private:

// UserScriptSet::Observer implementation.

- void OnUserScriptsUpdated(const std::set<std::string>& changed_extensions,

+ void OnUserScriptsUpdated(const std::set<HostID>& changed_hosts,

const std::vector<UserScript*>& scripts) override;

// ScriptInjector implementation.

@@ -67,8 +67,8 @@ class UserScriptInjector : public ScriptInjector,

// deleted.

int script_id_;

- // The associated extension id, preserved for the same reason as |script_id|.

- std::string extension_id_;

+ // The associated host id, preserved for the same reason as |script_id|.

+ HostID host_id_;

// Indicates whether or not this script is declarative. This influences which

// script permissions are checked before injection.