Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: extensions/common/extension_messages.h

Issue 988633003: Refactoring: de-couple Extensions from "script injection System" [render side]:4 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/common/extension_messages.h
diff --git a/extensions/common/extension_messages.h b/extensions/common/extension_messages.h
index 232167c224f15ec3eb77cb540d14c65a7d9a542c..11bce88f5eb3e15417a0518d2bbc2e8acce952e1 100644
--- a/extensions/common/extension_messages.h
+++ b/extensions/common/extension_messages.h
@@ -450,16 +450,17 @@ IPC_MESSAGE_ROUTED1(ExtensionMsg_ExecuteCode,
// handle is valid in the context of the renderer.
// If |owner| is not empty, then the shared memory handle refers to |owner|'s
// programmatically-defined scripts. Otherwise, the handle refers to all
-// extensions' statically defined scripts.
-// If |changed_extensions| is not empty, only the extensions in that set will
-// be updated. Otherwise, all extensions that have scripts in the shared memory
-// region will be updated. Note that the empty set => all extensions case is not
+// hosts' statically defined scripts. So for, only extension-hosts support
Devlin 2015/03/09 16:00:04 nit: so far, not so for.
Xi Han 2015/03/09 19:12:36 Oops, good catch.
+// statically defined scripts; WebUI-hosts don't.
+// If |changed_hosts| is not empty, only the host in that set will
+// be updated. Otherwise, all hosts that have scripts in the shared memory
+// region will be updated. Note that the empty set => all hosts case is not
// supported for per-extension programmatically-defined script regions; in such
-// regions, the owner is expected to list itself as the only changed extension.
+// regions, the owner is expected to list itself as the only changed host.
IPC_MESSAGE_CONTROL3(ExtensionMsg_UpdateUserScripts,
base::SharedMemoryHandle,
- extensions::ExtensionId /* owner */,
- std::set<std::string> /* changed extensions */)
+ HostID /* owner */,
+ std::set<HostID> /* changed hosts */)
// Trigger to execute declarative content script under browser control.
IPC_MESSAGE_ROUTED4(ExtensionMsg_ExecuteDeclarativeScript,

Powered by Google App Engine
This is Rietveld 408576698