Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: extensions/renderer/user_script_injector.h

Issue 988633003: Refactoring: de-couple Extensions from "script injection System" [render side]:4 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/renderer/script_injection_manager.cc ('k') | extensions/renderer/user_script_injector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/user_script_injector.h
diff --git a/extensions/renderer/user_script_injector.h b/extensions/renderer/user_script_injector.h
index c028b2dc3205d543db094e451830cfb968c9a74b..748fa297ea9dc94a5d0a9023d95d3db0679147bd 100644
--- a/extensions/renderer/user_script_injector.h
+++ b/extensions/renderer/user_script_injector.h
@@ -32,7 +32,7 @@ class UserScriptInjector : public ScriptInjector,
private:
// UserScriptSet::Observer implementation.
- void OnUserScriptsUpdated(const std::set<std::string>& changed_extensions,
+ void OnUserScriptsUpdated(const std::set<HostID>& changed_hosts,
const std::vector<UserScript*>& scripts) override;
// ScriptInjector implementation.
@@ -67,8 +67,8 @@ class UserScriptInjector : public ScriptInjector,
// deleted.
int script_id_;
- // The associated extension id, preserved for the same reason as |script_id|.
- std::string extension_id_;
+ // The associated host id, preserved for the same reason as |script_id|.
+ HostID host_id_;
// Indicates whether or not this script is declarative. This influences which
// script permissions are checked before injection.
« no previous file with comments | « extensions/renderer/script_injection_manager.cc ('k') | extensions/renderer/user_script_injector.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698