Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: extensions/browser/user_script_loader.cc

Issue 988633003: Refactoring: de-couple Extensions from "script injection System" [render side]:4 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/common/extension_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/user_script_loader.cc
diff --git a/extensions/browser/user_script_loader.cc b/extensions/browser/user_script_loader.cc
index c5b367c3b37d7b50ebf179e366c9c5884d3dd891..1a0571870782474a1c94e1bc64150f1659793002 100644
--- a/extensions/browser/user_script_loader.cc
+++ b/extensions/browser/user_script_loader.cc
@@ -494,15 +494,9 @@ void UserScriptLoader::SendUpdate(content::RenderProcessHost* process,
if (!shared_memory->ShareToProcess(handle, &handle_for_process))
return; // This can legitimately fail if the renderer asserts at startup.
- // TODO(hanxi): update the IPC message to send a set of HostIDs to render.
- // Also, remove this function when the refactor is done on render side.
- std::set<std::string> changed_ids_set;
- for (const HostID& id : changed_hosts)
- changed_ids_set.insert(id.id());
-
if (base::SharedMemory::IsHandleValid(handle_for_process)) {
- process->Send(new ExtensionMsg_UpdateUserScripts(
- handle_for_process, host_id().id(), changed_ids_set));
+ process->Send(new ExtensionMsg_UpdateUserScripts(handle_for_process,
+ host_id(), changed_hosts));
}
}
« no previous file with comments | « no previous file | extensions/common/extension_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698