Refactoring: de-couple Extensions from "script injection System" [render side]:4

Refactoring: de-couple Extensions from "script injection System" [render side]:4

Replace extension_id with host_id to avoid extension-specific check on webUI.

BUG=459234
Committed: https://crrev.com/3df97b200b7105e90e59703b3ee6d42581a3d125
Cr-Commit-Position: refs/heads/master@{#320185}

[Xi Han, 2015-03-06 23:15:35]

hanxi@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org

[Xi Han, 2015-03-08 14:49:23]

Patchset #2 (id:20001) has been deleted

[Xi Han, 2015-03-08 14:49:58]

Patchset #2 (id:40001) has been deleted

[Xi Han, 2015-03-08 14:50:17]

Patchset #1 (id:1) has been deleted

[Devlin, 2015-03-09 16:00:05]

Just a few small things.

https://codereview.chromium.org/988633003/diff/60001/extensions/common/extens...
File extensions/common/extension_messages.h (right):

https://codereview.chromium.org/988633003/diff/60001/extensions/common/extens...
extensions/common/extension_messages.h:453: // hosts' statically defined
scripts. So for, only extension-hosts support
nit: so far, not so for.

https://codereview.chromium.org/988633003/diff/60001/extensions/common/extens...
File extensions/common/extension_set.h (right):

https://codereview.chromium.org/988633003/diff/60001/extensions/common/extens...
extensions/common/extension_set.h:130: std::set<HostID> GetHostIDs() const;
This doesn't really belong here.  An ExtensionSet is an extensions concept, but
HostId is a script injection concept.

https://codereview.chromium.org/988633003/diff/60001/extensions/renderer/user...
File extensions/renderer/user_script_set_manager.cc (right):

https://codereview.chromium.org/988633003/diff/60001/extensions/renderer/user...
extensions/renderer/user_script_set_manager.cc:104: for
(std::set<HostID>::const_iterator iter = changed_hosts.begin();
range-based for-loop?

https://codereview.chromium.org/988633003/diff/60001/extensions/renderer/user...
extensions/renderer/user_script_set_manager.cc:115: // The expectation when
there is an host that "owns" this shared
a host, not an host.

[Xi Han, 2015-03-09 19:11:25]

Patchset #2 (id:80001) has been deleted

[Xi Han, 2015-03-09 19:12:37]

PTAL, thanks!

https://codereview.chromium.org/988633003/diff/60001/extensions/common/extens...
File extensions/common/extension_messages.h (right):

https://codereview.chromium.org/988633003/diff/60001/extensions/common/extens...
extensions/common/extension_messages.h:453: // hosts' statically defined
scripts. So for, only extension-hosts support
On 2015/03/09 16:00:04, Devlin wrote:
> nit: so far, not so for.

Oops, good catch.

https://codereview.chromium.org/988633003/diff/60001/extensions/common/extens...
File extensions/common/extension_set.h (right):

https://codereview.chromium.org/988633003/diff/60001/extensions/common/extens...
extensions/common/extension_set.h:130: std::set<HostID> GetHostIDs() const;
On 2015/03/09 16:00:04, Devlin wrote:
> This doesn't really belong here.  An ExtensionSet is an extensions concept,
but
> HostId is a script injection concept.

Moved to UserScriptSetManager.

https://codereview.chromium.org/988633003/diff/60001/extensions/renderer/user...
File extensions/renderer/user_script_set_manager.cc (right):

https://codereview.chromium.org/988633003/diff/60001/extensions/renderer/user...
extensions/renderer/user_script_set_manager.cc:104: for
(std::set<HostID>::const_iterator iter = changed_hosts.begin();
On 2015/03/09 16:00:05, Devlin wrote:
> range-based for-loop?

Done.

https://codereview.chromium.org/988633003/diff/60001/extensions/renderer/user...
extensions/renderer/user_script_set_manager.cc:115: // The expectation when
there is an host that "owns" this shared
On 2015/03/09 16:00:05, Devlin wrote:
> a host, not an host.

Done.

[Devlin, 2015-03-10 21:44:57]

Looks like you have a compile error

https://codereview.chromium.org/988633003/diff/100001/extensions/renderer/use...
File extensions/renderer/user_script_set_manager.cc (right):

https://codereview.chromium.org/988633003/diff/100001/extensions/renderer/use...
extensions/renderer/user_script_set_manager.cc:143: }
nit: else goes on the same line as the bracket (there should be lint warnings
for this...?)

[Xi Han, 2015-03-10 23:52:09]

I shouldn't start try-bot jobs since this patch was based on another CL. After
that one is landed, it should be fine:)

https://codereview.chromium.org/988633003/diff/100001/extensions/renderer/use...
File extensions/renderer/user_script_set_manager.cc (right):

https://codereview.chromium.org/988633003/diff/100001/extensions/renderer/use...
extensions/renderer/user_script_set_manager.cc:143: }
On 2015/03/10 21:44:57, Devlin wrote:
> nit: else goes on the same line as the bracket (there should be lint warnings
> for this...?)

Thanks for catching it again.

[Devlin, 2015-03-11 18:12:20]

lgtm

https://codereview.chromium.org/988633003/diff/120001/extensions/renderer/use...
File extensions/renderer/user_script_set_manager.cc (right):

https://codereview.chromium.org/988633003/diff/120001/extensions/renderer/use...
extensions/renderer/user_script_set_manager.cc:141: for (std::string
extension_id : extension_ids)
const std::string&

[Xi Han, 2015-03-11 19:03:53]

hanxi@chromium.org changed reviewers:
+ kenrb@chromium.org

[Xi Han, 2015-03-11 19:03:54]

kenrb@chromium.org: Please review changes in 
-extensions/common/extension_messages.h

Thanks!

[kenrb, 2015-03-11 19:14:04]

ipc lgtm

[Xi Han, 2015-03-11 19:14:29]

The CQ bit was checked by hanxi@chromium.org

[Xi Han, 2015-03-11 19:14:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
rdevlin.cronin@chromium.org
Link to the patchset: https://codereview.chromium.org/988633003/#ps140001
(title: "nits")

[commit-bot: I haz the power, 2015-03-11 19:38:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/988633003/140001

[commit-bot: I haz the power, 2015-03-11 21:18:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-11 21:18:20]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Xi Han, 2015-03-11 23:37:58]

The CQ bit was checked by hanxi@chromium.org

[commit-bot: I haz the power, 2015-03-11 23:38:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/988633003/140001

[commit-bot: I haz the power, 2015-03-11 23:40:25]

Committed patchset #4 (id:140001)

[commit-bot: I haz the power, 2015-03-11 23:41:27]

Patchset 4 (id:??) landed as
https://crrev.com/3df97b200b7105e90e59703b3ee6d42581a3d125
Cr-Commit-Position: refs/heads/master@{#320185}