Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1504)

Unified Diff: chrome/browser/extensions/extension_toolbar_model_unittest.cc

Issue 988633002: [CLEANUP] Rename some methods of ExtensionToolbarModel to be OnFoo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_toolbar_model_unittest.cc
diff --git a/chrome/browser/extensions/extension_toolbar_model_unittest.cc b/chrome/browser/extensions/extension_toolbar_model_unittest.cc
index c779b5558d597018d0df492b35a35e38939cf67e..4ccc363288883597e97b0c4044802978f3e595c4 100644
--- a/chrome/browser/extensions/extension_toolbar_model_unittest.cc
+++ b/chrome/browser/extensions/extension_toolbar_model_unittest.cc
@@ -53,28 +53,28 @@ class ExtensionToolbarModelTestObserver
private:
// ExtensionToolbarModel::Observer:
- void ToolbarExtensionAdded(const Extension* extension, int index) override {
+ void OnToolbarExtensionAdded(const Extension* extension, int index) override {
++inserted_count_;
}
- void ToolbarExtensionRemoved(const Extension* extension) override {
+ void OnToolbarExtensionRemoved(const Extension* extension) override {
++removed_count_;
}
- void ToolbarExtensionMoved(const Extension* extension, int index) override {
+ void OnToolbarExtensionMoved(const Extension* extension, int index) override {
++moved_count_;
}
- void ToolbarExtensionUpdated(const Extension* extension) override {}
+ void OnToolbarExtensionUpdated(const Extension* extension) override {}
bool ShowExtensionActionPopup(const Extension* extension,
bool grant_active_tab) override {
return false;
}
- void ToolbarVisibleCountChanged() override {}
+ void OnToolbarVisibleCountChanged() override {}
- void ToolbarHighlightModeChanged(bool is_highlighting) override {
+ void OnToolbarHighlightModeChanged(bool is_highlighting) override {
// Add one if highlighting, subtract one if not.
highlight_mode_count_ += is_highlighting ? 1 : -1;
}
« no previous file with comments | « chrome/browser/extensions/extension_toolbar_model.cc ('k') | chrome/browser/ui/toolbar/toolbar_actions_bar.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698