Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 988563002: Add an whitelist for calling GN's exec_script. (Closed)

Created:
5 years, 9 months ago by brettw
Modified:
5 years, 9 months ago
Reviewers:
scottmg
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add an whitelist for calling GN's exec_script. This will be used in Chrome to limit new callers and force root owners reviews for new uses of exec_script. This deletes the CommonSetup and DependentSetup class. Only the Setup class is used now. This was added to support generating .gyp files where there were many similar builds, but this functionality hasn't been used for ~1 year. Committed: https://crrev.com/4d305869607ee5ffff4df2caaa8ca2381e029193 Cr-Commit-Position: refs/heads/master@{#319517}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+202 lines, -216 lines) Patch
M tools/gn/build_settings.h View 3 chunks +12 lines, -0 lines 0 comments Download
M tools/gn/function_exec_script.cc View 2 chunks +40 lines, -0 lines 0 comments Download
M tools/gn/setup.h View 1 4 chunks +50 lines, -98 lines 0 comments Download
M tools/gn/setup.cc View 1 8 chunks +100 lines, -118 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
brettw
5 years, 9 months ago (2015-03-06 21:38:15 UTC) #2
scottmg
lgtm
5 years, 9 months ago (2015-03-06 21:42:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988563002/20001
5 years, 9 months ago (2015-03-06 21:44:57 UTC) #5
scottmg
Could you add a small test for this?
5 years, 9 months ago (2015-03-06 21:45:15 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-06 22:38:30 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-06 22:39:11 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4d305869607ee5ffff4df2caaa8ca2381e029193
Cr-Commit-Position: refs/heads/master@{#319517}

Powered by Google App Engine
This is Rietveld 408576698