Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 98853012: Revert of Remove uses of deprecated toWebCoreStringWithUndefinedOrNullCheck(v8::Handle<v8::Value>) (Closed)

Created:
7 years ago by pfeldman
Modified:
7 years ago
Reviewers:
haraken, Inactive
CC:
blink-reviews, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, Nils Barth (inactive), caseq+blink_chromium.org, Nate Chapin, arv+blink, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, devtools-reviews_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, kojih, jsbell+bindings_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of https://codereview.chromium.org/110663003/ Reason for revert: The new code is unreadable. TBR=haraken@chromium.org,ch.dumez@samsung.com NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163511

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -70 lines) Patch
D LayoutTests/fast/dom/Window/showModalDialog-invalid-arguments.html View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/fast/dom/Window/showModalDialog-invalid-arguments-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
M Source/bindings/v8/PageScriptDebugServer.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/v8/ScriptDebugServer.cpp View 3 chunks +8 lines, -23 lines 0 comments Download
M Source/bindings/v8/V8Binding.h View 1 chunk +9 lines, -0 lines 0 comments Download
M Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp View 2 chunks +4 lines, -5 lines 0 comments Download
M Source/bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/custom/V8WindowCustom.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/inspector/JavaScriptCallFrame.cpp View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pfeldman
Created Revert of Remove uses of deprecated toWebCoreStringWithUndefinedOrNullCheck(v8::Handle<v8::Value>)
7 years ago (2013-12-10 07:49:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pfeldman@chromium.org/98853012/1
7 years ago (2013-12-10 07:49:41 UTC) #2
commit-bot: I haz the power
7 years ago (2013-12-10 07:49:56 UTC) #3
Message was sent while issue was closed.
Change committed as 163511

Powered by Google App Engine
This is Rietveld 408576698