Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 98853002: StubCompiler gets extra_ic_state member. (Closed)

Created:
7 years ago by mvstanton
Modified:
7 years ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Visibility:
Public.

Description

Removed pieces of extra_ic_state scattered around the stub compiler class hierarchy, and pushed down to a extra_ic_state in the base class. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18185

Patch Set 1 #

Patch Set 2 : Platform ports. #

Total comments: 2

Patch Set 3 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -55 lines) Patch
M src/arm/stub-cache-arm.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M src/ic.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/stub-cache-mips.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M src/stub-cache.h View 1 2 13 chunks +25 lines, -23 lines 0 comments Download
M src/stub-cache.cc View 8 chunks +14 lines, -15 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
mvstanton
PTAL, thx! --Michael
7 years ago (2013-12-02 11:08:45 UTC) #1
Toon Verwaest
I like this change. Just one comment. https://codereview.chromium.org/98853002/diff/20001/src/stub-cache.h File src/stub-cache.h (right): https://codereview.chromium.org/98853002/diff/20001/src/stub-cache.h#newcode840 src/stub-cache.h:840: return StoreIC::GetStrictMode(extra_state()); ...
7 years ago (2013-12-02 11:44:31 UTC) #2
mvstanton
Hi Toon, Thx for comments. Indeed, I could remove strict_mode(). --Michael https://codereview.chromium.org/98853002/diff/20001/src/stub-cache.h File src/stub-cache.h (right): ...
7 years ago (2013-12-02 11:48:50 UTC) #3
Toon Verwaest
lgtm.
7 years ago (2013-12-02 11:50:16 UTC) #4
mvstanton
7 years ago (2013-12-02 11:59:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r18185 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698