Source/core/layout/LayoutGrid.cpp - Issue 988523003: Reimplement min-width: auto

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/layout/LayoutGrid.cpp

Issue 988523003: Reimplement min-width: auto (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: rebased Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/layout/LayoutFlexibleBox.cpp ('K') | « Source/core/layout/LayoutFlexibleBox.cpp ('k') | Source/core/layout/LayoutMenuList.cpp » ('j') | Source/devtools/front_end/inspectorCommon.css » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/layout/LayoutGrid.cpp

diff --git a/Source/core/layout/LayoutGrid.cpp b/Source/core/layout/LayoutGrid.cpp

index e1cecf43798c952b6bf443784d1ca73fe5be0156..39080b90138e4aa1ae1929ff5b60570722d9be5e 100644

--- a/Source/core/layout/LayoutGrid.cpp

+++ b/Source/core/layout/LayoutGrid.cpp

@@ -527,7 +527,7 @@ LayoutUnit LayoutGrid::computeUsedBreadthOfSpecifiedLength(GridTrackSizingDirect

{

ASSERT(trackLength.isSpecified());

// FIXME: The -1 here should be replaced by whatever the intrinsic height of the grid is.

- return valueForLength(trackLength, direction == ForColumns ? logicalWidth() : std::max(LayoutUnit(), computeContentLogicalHeight(style()->logicalHeight(), -1)));

+ return valueForLength(trackLength, direction == ForColumns ? logicalWidth() : std::max(LayoutUnit(), computeContentLogicalHeight(MainOrPreferredSize, style()->logicalHeight(), -1)));

}

static bool sortByGridNormalizedFlexValue(const GridTrackForNormalization& track1, const GridTrackForNormalization& track2)