sdk/lib/_internal/compiler/js_lib/js_number.dart - Issue 988523002: Fix int.parse bug (dart2js version)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/js_lib/js_number.dart

Issue 988523002: Fix int.parse bug (dart2js version) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sdk/lib/_internal/compiler/js_lib/js_number.dart

diff --git a/sdk/lib/_internal/compiler/js_lib/js_number.dart b/sdk/lib/_internal/compiler/js_lib/js_number.dart

index c05f4f48173b1f930bb84ce15aff8ae4e0bc6612..c1357e02f73026ea9207f32b86a29d26cc44d01b 100644

--- a/sdk/lib/_internal/compiler/js_lib/js_number.dart

+++ b/sdk/lib/_internal/compiler/js_lib/js_number.dart

@@ -167,7 +167,9 @@ class JSNumber extends Interceptor implements num {

String toRadixString(int radix) {

checkInt(radix);

- if (radix < 2 || radix > 36) throw new RangeError(radix);

+ if (radix < 2 || radix > 36) {

+ throw new RangeError.range(radix, 2, 36, "radix");

+ }

String result = JS('String', r'#.toString(#)', this, radix);

const int rightParenCode = 0x29;

if (result.codeUnitAt(result.length - 1) != rightParenCode) {

« no previous file with comments | « sdk/lib/_internal/compiler/js_lib/js_helper.dart ('k') | sdk/lib/core/int.dart » ('j') | no next file with comments »