Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 988513003: Switch the order of experimental global initialization and running natives. (Closed)

Created:
5 years, 9 months ago by Dmitry Lomov (no reviews)
Modified:
5 years, 9 months ago
Reviewers:
Yang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Switch the order of experimental global initialization and running natives. The order should match the one for normal natives. R=yangguo@chromium.org Committed: https://crrev.com/c071af5ae34cdb179f12efefdb93064e2e2f17fd Cr-Commit-Position: refs/heads/master@{#27165}

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M src/bootstrapper.cc View 3 chunks +10 lines, -12 lines 0 comments Download
M src/regexp.js View 1 1 chunk +2 lines, -0 lines 2 comments Download

Messages

Total messages: 15 (5 generated)
Dmitry Lomov (no reviews)
PTAL
5 years, 9 months ago (2015-03-12 14:02:40 UTC) #1
Yang
On 2015/03/12 14:02:40, Dmitry Lomov (chromium) wrote: > PTAL lgtm.
5 years, 9 months ago (2015-03-12 14:20:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988513003/1
5 years, 9 months ago (2015-03-12 14:34:03 UTC) #4
commit-bot: I haz the power
Failed to apply patch for src/regexp.js: While running git apply --index -3 -p1; error: patch ...
5 years, 9 months ago (2015-03-12 14:58:58 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988513003/20001
5 years, 9 months ago (2015-03-12 15:25:20 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-12 15:44:40 UTC) #11
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/c071af5ae34cdb179f12efefdb93064e2e2f17fd Cr-Commit-Position: refs/heads/master@{#27165}
5 years, 9 months ago (2015-03-12 15:44:51 UTC) #12
arv (Not doing code reviews)
FYI https://codereview.chromium.org/988513003/diff/20001/src/regexp.js File src/regexp.js (right): https://codereview.chromium.org/988513003/diff/20001/src/regexp.js#newcode9 src/regexp.js:9: var harmony_regexps = false; Why the underscores? JS ...
5 years, 9 months ago (2015-03-12 15:47:30 UTC) #13
Jakob Kummerow
https://codereview.chromium.org/988513003/diff/20001/src/regexp.js File src/regexp.js (right): https://codereview.chromium.org/988513003/diff/20001/src/regexp.js#newcode9 src/regexp.js:9: var harmony_regexps = false; On 2015/03/12 15:47:30, arv wrote: ...
5 years, 9 months ago (2015-03-12 16:05:36 UTC) #14
Dmitry Lomov (no reviews)
5 years, 9 months ago (2015-03-12 16:40:15 UTC) #15
Message was sent while issue was closed.
On 2015/03/12 15:47:30, arv wrote:
> FYI
> 
> https://codereview.chromium.org/988513003/diff/20001/src/regexp.js
> File src/regexp.js (right):
> 
> https://codereview.chromium.org/988513003/diff/20001/src/regexp.js#newcode9
> src/regexp.js:9: var harmony_regexps = false;
> Why the underscores? JS style is camelCase.

[Note that this CL does not introduce the variable, just changes the way it is
declared]

Consistency with how the flag is called in the rest of V8 code (I want to be
able to do 'git grep harmony_regexps')

Powered by Google App Engine
This is Rietveld 408576698