Add widget to display errors, and report dependency_graph errors correctly

test/dependency_graph_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dev_compiler.test.dependency_graph_test;
 
 import 'package:unittest/compact_vm_config.dart';
 import 'package:unittest/unittest.dart';
 
 import 'package:dev_compiler/src/checker/dart_sdk.dart'
     show mockSdkSources, dartSdkDirectory;
 import 'package:dev_compiler/src/testing.dart';
 import 'package:dev_compiler/src/options.dart';
 import 'package:dev_compiler/src/checker/resolver.dart';
 import 'package:dev_compiler/src/dependency_graph.dart';
+import 'package:dev_compiler/src/report.dart';
 import 'package:path/path.dart' as path;
 
 main() {
   groupSep = " > ";
   useCompactVMConfiguration();
 
   var options = new CompilerOptions();
   var testUriResolver;
   var context;
   var graph;
@@ skipping 30 matching lines @@
   };
 
   nodeOf(String filepath) => graph.nodeFromUri(new Uri.file(filepath));
 
   setUp(() {
     /// We completely reset the TestUriResolver to avoid interference between
     /// tests (since some tests modify the state of the files).
     testUriResolver = new TestUriResolver(testFiles);
     context = new TypeResolver.fromMock(mockSdkSources, options,
         otherResolvers: [testUriResolver]).context;
-    graph = new SourceGraph(context, options);
+    graph = new SourceGraph(context, new LogReporter());
   });
 
   group('HTML deps', () {
     test('initial deps', () {
       var i1 = nodeOf('/index1.html');
       var i2 = nodeOf('/index2.html');
       expect(i1.scripts.length, 0);
       expect(i2.scripts.length, 0);
       i1.update(graph);
       i2.update(graph);
@@ skipping 470 matching lines @@
     });
   });
 
   group('refresh structure and marks', () {
     test('initial marks', () {
       var node = nodeOf('/index3.html');
       expectGraph(node, '''
           index3.html
           |-- dart_runtime.js
           |-- harmony_feature_check.js
+          |-- messages_widget.js
+          |-- messages.css
           ''');
       refreshStructureAndMarks(node, graph);
       expectGraph(node, '''
           index3.html [needs-rebuild] [structure-changed]
           |-- a2.dart [needs-rebuild] [structure-changed]
           |    |-- a3.dart [needs-rebuild]
           |    |-- a4.dart [needs-rebuild] [structure-changed]
           |    |    |-- a10.dart [needs-rebuild]
           |    |-- a5.dart [needs-rebuild]
           |    |-- a6.dart (part) [needs-rebuild]
           |-- dart_runtime.js [needs-rebuild]
           |-- harmony_feature_check.js [needs-rebuild]
+          |-- messages_widget.js [needs-rebuild]
+          |-- messages.css [needs-rebuild]
           ''');
     });
 
     test('cleared marks stay clear', () {
       var node = nodeOf('/index3.html');
       refreshStructureAndMarks(node, graph);
       expectGraph(node, '''
           index3.html [needs-rebuild] [structure-changed]
           |-- a2.dart [needs-rebuild] [structure-changed]
           |    |-- a3.dart [needs-rebuild]
           |    |-- a4.dart [needs-rebuild] [structure-changed]
           |    |    |-- a10.dart [needs-rebuild]
           |    |-- a5.dart [needs-rebuild]
           |    |-- a6.dart (part) [needs-rebuild]
           |-- dart_runtime.js [needs-rebuild]
           |-- harmony_feature_check.js [needs-rebuild]
+          |-- messages_widget.js [needs-rebuild]
+          |-- messages.css [needs-rebuild]
           ''');
       clearMarks(node);
       expectGraph(node, '''
           index3.html
           |-- a2.dart
           |    |-- a3.dart
           |    |-- a4.dart
           |    |    |-- a10.dart
           |    |-- a5.dart
           |    |-- a6.dart (part)
           |-- dart_runtime.js
           |-- harmony_feature_check.js
+          |-- messages_widget.js
+          |-- messages.css
           ''');
 
       refreshStructureAndMarks(node, graph);
       expectGraph(node, '''
           index3.html
           |-- a2.dart
           |    |-- a3.dart
           |    |-- a4.dart
           |    |    |-- a10.dart
           |    |-- a5.dart
           |    |-- a6.dart (part)
           |-- dart_runtime.js
           |-- harmony_feature_check.js
+          |-- messages_widget.js
+          |-- messages.css
           ''');
     });
 
     test('needsRebuild mark updated on local modifications', () {
       var node = nodeOf('/index3.html');
       refreshStructureAndMarks(node, graph);
       clearMarks(node);
       var a3 = nodeOf('/a3.dart');
       a3.source.contents.modificationTime++;
 
       refreshStructureAndMarks(node, graph);
       expectGraph(node, '''
           index3.html
           |-- a2.dart
           |    |-- a3.dart [needs-rebuild]
           |    |-- a4.dart
           |    |    |-- a10.dart
           |    |-- a5.dart
           |    |-- a6.dart (part)
           |-- dart_runtime.js
           |-- harmony_feature_check.js
+          |-- messages_widget.js
+          |-- messages.css
           ''');
     });
 
     test('structuredChanged mark updated on structure modifications', () {
       var node = nodeOf('/index3.html');
       refreshStructureAndMarks(node, graph);
       clearMarks(node);
       var a5 = nodeOf('/a5.dart');
       a5.source.contents.modificationTime++;
       a5.source.contents.data = 'import "a8.dart";';
 
       refreshStructureAndMarks(node, graph);
       expectGraph(node, '''
           index3.html
           |-- a2.dart
           |    |-- a3.dart
           |    |-- a4.dart
           |    |    |-- a10.dart
           |    |-- a5.dart [needs-rebuild] [structure-changed]
           |    |    |-- a8.dart [needs-rebuild] [structure-changed]
           |    |    |    |-- a8.dart...
           |    |-- a6.dart (part)
           |-- dart_runtime.js
           |-- harmony_feature_check.js
+          |-- messages_widget.js
+          |-- messages.css
           ''');
     });
   });
 
   group('rebuild', () {
     var results;
     void addName(SourceNode n) => results.add(nameFor(n));
 
     bool buildNoTransitiveChange(SourceNode n) {
       addName(n);
@@ skipping 14 matching lines @@
       rebuild(node, graph, buildNoTransitiveChange);
       // Note: a6.dart is not included because it built as part of a2.dart
       expect(results, [
         'a3.dart',
         'a10.dart',
         'a4.dart',
         'a5.dart',
         'a2.dart',
         'dart_runtime.js',
         'harmony_feature_check.js',
+        'messages_widget.js',
+        'messages.css',
         'index3.html',
       ]);
 
       // Marks are removed automatically by rebuild
       expectGraph(node, '''
           index3.html
           |-- a2.dart
           |    |-- a3.dart
           |    |-- a4.dart
           |    |    |-- a10.dart
           |    |-- a5.dart
           |    |-- a6.dart (part)
           |-- dart_runtime.js
           |-- harmony_feature_check.js
+          |-- messages_widget.js
+          |-- messages.css
           ''');
     });
 
     test('nothing to do after build', () {
       var node = nodeOf('/index3.html');
       rebuild(node, graph, buildNoTransitiveChange);
 
       results = [];
       rebuild(node, graph, buildNoTransitiveChange);
       expect(results, []);
@@ skipping 132 matching lines @@
         expectGraph(node, '''
             index3.html
             |-- a2.dart
             |    |-- a3.dart
             |    |-- a4.dart
             |    |    |-- a10.dart
             |    |-- a5.dart
             |    |-- a6.dart (part)
             |-- dart_runtime.js
             |-- harmony_feature_check.js
+            |-- messages_widget.js
+            |-- messages.css
             ''');
 
         // Modify the file first:
         a6.source.contents.modificationTime++;
         a6.source.contents.data = 'library a6; import "a5.dart";';
         results = [];
         rebuild(node, graph, buildNoTransitiveChange);
 
         // Looks to us like a change in a part, we'll report errors that the
         // part is not really a part-file. Note that a6.dart is not included
         // below, because we don't build it as a library.
         expect(results, ['a2.dart']);
         expectGraph(node, '''
             index3.html
             |-- a2.dart
             |    |-- a3.dart
             |    |-- a4.dart
             |    |    |-- a10.dart
             |    |-- a5.dart
             |    |-- a6.dart (part)
             |-- dart_runtime.js
             |-- harmony_feature_check.js
+            |-- messages_widget.js
+            |-- messages.css
             ''');
 
         a2.source.contents.modificationTime++;
         a2.source.contents.data = '''
             library a2;
             import 'a3.dart';
             import 'a4.dart';
             import 'a6.dart'; // properly import it
             export 'a5.dart';
           ''';
@@ skipping 12 matching lines @@
             index3.html
             |-- a2.dart
             |    |-- a3.dart
             |    |-- a4.dart
             |    |    |-- a10.dart
             |    |-- a6.dart
             |    |    |-- a5.dart
             |    |-- a5.dart...
             |-- dart_runtime.js
             |-- harmony_feature_check.js
+            |-- messages_widget.js
+            |-- messages.css
             ''');
       });
 
       test('convert part to a library after updating the import', () {
         var node = nodeOf('/index3.html');
         var a2 = nodeOf('/a2.dart');
         var a6 = nodeOf('/a6.dart');
         rebuild(node, graph, buildNoTransitiveChange);
 
         expectGraph(node, '''
             index3.html
             |-- a2.dart
             |    |-- a3.dart
             |    |-- a4.dart
             |    |    |-- a10.dart
             |    |-- a5.dart
             |    |-- a6.dart (part)
             |-- dart_runtime.js
             |-- harmony_feature_check.js
+            |-- messages_widget.js
+            |-- messages.css
             ''');
 
         a2.source.contents.modificationTime++;
         a2.source.contents.data = '''
             library a2;
             import 'a3.dart';
             import 'a4.dart';
             import 'a6.dart'; // properly import it
             export 'a5.dart';
           ''';
         results = [];
         rebuild(node, graph, buildNoTransitiveChange);
         expect(results, ['a6.dart', 'a2.dart', 'index3.html']);
         expectGraph(node, '''
             index3.html
             |-- a2.dart
             |    |-- a3.dart
             |    |-- a4.dart
             |    |    |-- a10.dart
             |    |-- a6.dart
             |    |-- a5.dart
             |-- dart_runtime.js
             |-- harmony_feature_check.js
+            |-- messages_widget.js
+            |-- messages.css
             ''');
 
         a6.source.contents.modificationTime++;
         a6.source.contents.data = 'library a6; import "a5.dart";';
         results = [];
         rebuild(node, graph, buildNoTransitiveChange);
         expect(results, ['a6.dart', 'index3.html']);
         expectGraph(node, '''
             index3.html
             |-- a2.dart
             |    |-- a3.dart
             |    |-- a4.dart
             |    |    |-- a10.dart
             |    |-- a6.dart
             |    |    |-- a5.dart
             |    |-- a5.dart...
             |-- dart_runtime.js
             |-- harmony_feature_check.js
+            |-- messages_widget.js
+            |-- messages.css
             ''');
       });
 
       test('disconnect part making it a library', () {
         var node = nodeOf('/index3.html');
         var a2 = nodeOf('/a2.dart');
         var a6 = nodeOf('/a6.dart');
         rebuild(node, graph, buildNoTransitiveChange);
 
         expectGraph(node, '''
             index3.html
             |-- a2.dart
             |    |-- a3.dart
             |    |-- a4.dart
             |    |    |-- a10.dart
             |    |-- a5.dart
             |    |-- a6.dart (part)
             |-- dart_runtime.js
             |-- harmony_feature_check.js
+            |-- messages_widget.js
+            |-- messages.css
             ''');
 
         a2.source.contents.modificationTime++;
         a2.source.contents.data = '''
             library a2;
             import 'a3.dart';
             import 'a4.dart';
             export 'a5.dart';
           ''';
         a6.source.contents.modificationTime++;
         a6.source.contents.data = 'library a6; import "a5.dart";';
         results = [];
         rebuild(node, graph, buildNoTransitiveChange);
         // a6 is not here, it's not reachable so we don't build it.
         expect(results, ['a2.dart', 'index3.html']);
         expectGraph(node, '''
             index3.html
             |-- a2.dart
             |    |-- a3.dart
             |    |-- a4.dart
             |    |    |-- a10.dart
             |    |-- a5.dart
             |-- dart_runtime.js
             |-- harmony_feature_check.js
+            |-- messages_widget.js
+            |-- messages.css
             ''');
       });
 
       test('convert a library to a part', () {
         var node = nodeOf('/index3.html');
         var a2 = nodeOf('/a2.dart');
         var a5 = nodeOf('/a5.dart');
         rebuild(node, graph, buildNoTransitiveChange);
 
         expectGraph(node, '''
             index3.html
             |-- a2.dart
             |    |-- a3.dart
             |    |-- a4.dart
             |    |    |-- a10.dart
             |    |-- a5.dart
             |    |-- a6.dart (part)
             |-- dart_runtime.js
             |-- harmony_feature_check.js
+            |-- messages_widget.js
+            |-- messages.css
             ''');
 
         a2.source.contents.modificationTime++;
         a2.source.contents.data = '''
             library a2;
             import 'a3.dart';
             import 'a4.dart';
             part 'a5.dart'; // make it a part
             part 'a6.dart';
           ''';
         results = [];
         rebuild(node, graph, buildNoTransitiveChange);
         expect(results, ['a2.dart', 'index3.html']);
         expectGraph(node, '''
             index3.html
             |-- a2.dart
             |    |-- a3.dart
             |    |-- a4.dart
             |    |    |-- a10.dart
             |    |-- a5.dart (part)
             |    |-- a6.dart (part)
             |-- dart_runtime.js
             |-- harmony_feature_check.js
+            |-- messages_widget.js
+            |-- messages.css
             ''');
 
         a5.source.contents.modificationTime++;
         a5.source.contents.data = 'part of a2;';
         results = [];
         rebuild(node, graph, buildNoTransitiveChange);
         expect(results, ['a2.dart']);
         expectGraph(node, '''
             index3.html
             |-- a2.dart
             |    |-- a3.dart
             |    |-- a4.dart
             |    |    |-- a10.dart
             |    |-- a5.dart (part)
             |    |-- a6.dart (part)
             |-- dart_runtime.js
             |-- harmony_feature_check.js
+            |-- messages_widget.js
+            |-- messages.css
             ''');
       });
     });
   });
 }
 
 expectGraph(SourceNode node, String expectation) {
   expect(printReachable(node), equalsIgnoringWhitespace(expectation));
 }
 
@@ skipping 30 matching lines @@
           ..write(e.structureChanged ? '[structure-changed] ' : ' ')
           ..write('\n');
       });
     }
   }
   helper(node);
   return sb.toString();
 }
 
 bool _same(Set a, Set b) => a.length == b.length && a.containsAll(b);