Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 988483006: Add widget to display errors, and report dependency_graph errors correctly (Closed)

Created:
5 years, 9 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 9 months ago
Reviewers:
vsm, Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add widget to display errors, and report graph errors correctly. This fixes the compiler so that all error messages in dependency_graph are reported via the reporter and unifies how errors are constructed in other places as well. With all errors reported together, we use a widget (adapted from polymer) to display the error messages as part of the app in server mode. R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/33503c554e71cae6b2834802e5873043361987fb

Patch Set 1 : #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+7059 lines, -299 lines) Patch
M bin/edit_files.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/devc.dart View 8 chunks +22 lines, -18 lines 0 comments Download
A lib/runtime/messages.css View 1 chunk +78 lines, -0 lines 1 comment Download
A lib/runtime/messages_widget.dart View 1 chunk +120 lines, -0 lines 1 comment Download
A lib/runtime/messages_widget.js View 1 chunk +6377 lines, -0 lines 1 comment Download
M lib/src/checker/resolver.dart View 2 chunks +19 lines, -8 lines 2 comments Download
M lib/src/codegen/html_codegen.dart View 2 chunks +18 lines, -7 lines 0 comments Download
M lib/src/dependency_graph.dart View 10 chunks +39 lines, -25 lines 0 comments Download
M lib/src/info.dart View 2 chunks +10 lines, -7 lines 0 comments Download
M lib/src/report.dart View 4 chunks +104 lines, -222 lines 1 comment Download
A lib/src/summary.dart View 1 chunk +212 lines, -0 lines 1 comment Download
M lib/src/testing.dart View 2 chunks +10 lines, -8 lines 0 comments Download
M test/dependency_graph_test.dart View 22 chunks +42 lines, -1 line 0 comments Download
M test/report_test.dart View 1 chunk +1 line, -0 lines 0 comments Download
M test/test.sh View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
Siggi Cherem (dart-lang)
(FYI - this CL is built on top of others, I'm only showing the diff ...
5 years, 9 months ago (2015-03-07 02:43:02 UTC) #6
vsm
lgtm https://codereview.chromium.org/988483006/diff/80001/lib/src/checker/resolver.dart File lib/src/checker/resolver.dart (right): https://codereview.chromium.org/988483006/diff/80001/lib/src/checker/resolver.dart#newcode83 lib/src/checker/resolver.dart:83: reporter.log(message); On 2015/03/07 02:43:01, Siggi Cherem (dart-lang) wrote: ...
5 years, 9 months ago (2015-03-09 15:14:36 UTC) #7
Siggi Cherem (dart-lang)
5 years, 9 months ago (2015-03-09 18:37:27 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:80001) manually as
33503c554e71cae6b2834802e5873043361987fb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698