Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1184)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 988453002: Request uncompressed images from data reduction proxy when saving. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: whitespace change Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index d47a6ef362c8157626ee30e86106e2604b0cfb80..b5bcb407b442f5d354cf13e366d48f3bf38a0e18 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -2294,8 +2294,9 @@ bool WebContentsImpl::SavePage(const base::FilePath& main_file,
return save_package_->Init(SavePackageDownloadCreatedCallback());
}
-void WebContentsImpl::SaveFrame(const GURL& url,
- const Referrer& referrer) {
+void WebContentsImpl::SaveFrameWithHeader(const GURL& url,
+ const Referrer& referrer,
+ const std::string& header) {
if (!GetURL().is_valid())
return;
if (delegate_ && delegate_->SaveFrame(url, referrer))
@@ -2321,9 +2322,26 @@ void WebContentsImpl::SaveFrame(const GURL& url,
if (post_id >= 0)
params->set_method("POST");
params->set_prompt(true);
+
+ if (!header.empty()) {
+ std::vector<std::string> keyValueList;
Avi (use Gerrit) 2015/03/05 20:35:39 style, please! key_value_list
Not at Google. Contact bengr 2015/03/06 22:23:48 Done.
+ base::SplitString(header, '\n', &keyValueList);
+ for (std::vector<std::string>::iterator it = keyValueList.begin();
Avi (use Gerrit) 2015/03/05 20:35:39 for (auto& ...)
Not at Google. Contact bengr 2015/03/06 22:23:48 Done.
+ it != keyValueList.end(); it++) {
+ std::vector<std::string> pair;
+ base::SplitString(*it, ':', &pair);
+ DCHECK(pair.size() == 2);
Avi (use Gerrit) 2015/03/05 20:35:39 DCHECK_EQ
Not at Google. Contact bengr 2015/03/06 22:23:48 Done.
+ params->add_request_header(pair[0], pair[1]);
+ }
+ }
dlm->DownloadUrl(params.Pass());
}
+void WebContentsImpl::SaveFrame(const GURL& url,
+ const Referrer& referrer) {
+ SaveFrameWithHeader(url, referrer, "");
Avi (use Gerrit) 2015/03/05 20:35:39 "" -> std::string()
Not at Google. Contact bengr 2015/03/06 22:23:48 Done.
+}
+
void WebContentsImpl::GenerateMHTML(
const base::FilePath& file,
const base::Callback<void(int64)>& callback) {

Powered by Google App Engine
This is Rietveld 408576698