Request uncompressed images from data reduction proxy when saving.

chrome/browser/renderer_context_menu/render_view_context_menu.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
 
 #include <algorithm>
 #include <set>
 #include <utility>
 
@@ skipping 1372 matching lines @@
           params_.src_url.is_empty();
       if (params_.media_type == WebContextMenuData::MediaTypeCanvas ||
           (params_.media_type == WebContextMenuData::MediaTypeImage &&
               is_large_data_url)) {
         source_web_contents_->GetRenderViewHost()->SaveImageAt(
           params_.x, params_.y);
       } else {
         RecordDownloadSource(DOWNLOAD_INITIATED_BY_CONTEXT_MENU);
         const GURL& url = params_.src_url;
         content::Referrer referrer = CreateSaveAsReferrer(url, params_);
-        source_web_contents_->SaveFrame(url, referrer);
+
+        std::string header = "";

[Avi (use Gerrit), 2015/03/05 20:35:39]

Drop the assignment; strings are constructed empty.

[Not at Google. Contact bengr, 2015/03/06 22:23:48]

Done.

+        if (!browser_context_->IsOffTheRecord() &&

[Avi (use Gerrit), 2015/03/05 20:35:39]

I'm not thrilled with the idea of using the knowledge that there is no proxy for
incognito sessions here.

What does DataReductionProxyChromeSettingsFactory::GetForBrowserContext return
for an incognito session? If nullptr, then I'd much rather you do:

std::string header;
DataReductionProxyChromeSettings* settings =
DataReductionProxyChromeSettingsFactory::GetForBrowserContext(browser_context);
if (settings && settings->CanUseDataReductionProxy(params_.src_url))
  header = data_reduction_proxy::kDataReductionPassThroughHeader;

[Not at Google. Contact bengr, 2015/03/06 22:23:48]

Unfortunately, DataReductionProxyChromeSettingsFactory::GetForBrowserContext
does not return a null for incognito. It returns a valid object.

[Avi (use Gerrit), 2015/03/06 23:55:20]

This is even weirder then. I'm assuming that there is no proxying done with
incognito. So why where would there be a valid factory?

It's rather unfortunate that everyone who calls
DataReductionProxyChromeSettingsFactory has to know not to call it for incognito
contexts. It would be nice if that knowledge were in the
DataReductionProxyChromeSettingsFactory.

[Not at Google. Contact bengr, 2015/03/07 00:45:02]

Done.

Even though DataReductionProxyChromeSettingsFactory doesn't differentiate
incognito, I realized that the default implementation in
BrowserContextKeyedBaseFactory is to return a null for incognito. So
DataReductionProxyChromeSettingsFactory::GetForBrowserContext(browser_context)
does indeed return null for incognito. Fixed another occurance of this check as
well.

+            DataReductionProxyChromeSettingsFactory::GetForBrowserContext(
+                browser_context_)->CanUseDataReductionProxy(
+                    params_.src_url)) {
+          header = data_reduction_proxy::kDataReductionPassThroughHeader;
+        }
+
+        source_web_contents_->SaveFrameWithHeader(url, referrer, header);
       }
       break;
     }
 
     case IDC_CONTENT_CONTEXT_COPYLINKLOCATION:
       WriteURLToClipboard(params_.unfiltered_link_url);
       break;
 
     case IDC_CONTENT_CONTEXT_COPYIMAGELOCATION:
     case IDC_CONTENT_CONTEXT_COPYAVLOCATION:
@@ skipping 400 matching lines @@
   source_web_contents_->GetRenderViewHost()->
       ExecuteMediaPlayerActionAtLocation(location, action);
 }
 
 void RenderViewContextMenu::PluginActionAt(
     const gfx::Point& location,
     const WebPluginAction& action) {
   source_web_contents_->GetRenderViewHost()->
       ExecutePluginActionAtLocation(location, action);
 }