Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 988423003: [turbofan] Fix --turbo-osr for OSRing into inner loop inside for-in. (Closed)

Created:
5 years, 9 months ago by titzer
Modified:
5 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix --turbo-osr for OSRing into inner loop inside for-in. R=mstarzinger@chromium.org BUG=chromium:462775 LOG=Y Committed: https://crrev.com/0b3f4af12c29304407462903f873146c4fe9b6b8 Cr-Commit-Position: refs/heads/master@{#27088}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M src/compiler/ast-graph-builder.cc View 1 3 1 chunk +2 lines, -0 lines 0 comments Download
A test/mjsunit/compiler/osr-forin-nested.js View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
titzer
5 years, 9 months ago (2015-03-09 18:13:47 UTC) #1
Michael Starzinger
5 years, 9 months ago (2015-03-09 18:20:56 UTC) #2
Michael Starzinger
LGTM.
5 years, 9 months ago (2015-03-09 18:21:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988423003/1
5 years, 9 months ago (2015-03-09 18:27:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/646)
5 years, 9 months ago (2015-03-09 18:44:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988423003/40001
5 years, 9 months ago (2015-03-10 08:36:11 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_nodcheck_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel/builds/657)
5 years, 9 months ago (2015-03-10 09:00:02 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988423003/60001
5 years, 9 months ago (2015-03-10 09:04:20 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 9 months ago (2015-03-10 09:27:39 UTC) #16
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 09:27:48 UTC) #17
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/0b3f4af12c29304407462903f873146c4fe9b6b8
Cr-Commit-Position: refs/heads/master@{#27088}

Powered by Google App Engine
This is Rietveld 408576698