Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 988413002: Fix CompilerHints flag order to match FunctionKind. (Closed)

Created:
5 years, 9 months ago by marja
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix CompilerHints flag order to match FunctionKind. The bits in CompilerHints are accessed via FunctionKindBits, and on the other hand, with accessors defined by BOOL_ACCESSORS(SharedFunctionInfo, compiler_hints, is_accessor_function, kIsAccessorFunction) etc. So the bit order in FunctionKind must match CompilerHints. This is not causing problems (yet) because there's no accessor for these two bits, but if somebody adds one, things will go wrong. R=dslomov@chromium.org BUG= Committed: https://crrev.com/3ff7da93d81eb7612d4fd3a0341915d4641de175 Cr-Commit-Position: refs/heads/master@{#27096}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/objects.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
marja
dslomov, ptal. (Is the "why is this not a problem" diagnosed right?)
5 years, 9 months ago (2015-03-09 15:34:54 UTC) #1
Dmitry Lomov (no reviews)
CL description has an incomplete sentence otherwise lgtm
5 years, 9 months ago (2015-03-10 10:42:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988413002/1
5 years, 9 months ago (2015-03-10 10:49:50 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 11:57:12 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 11:57:27 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3ff7da93d81eb7612d4fd3a0341915d4641de175
Cr-Commit-Position: refs/heads/master@{#27096}

Powered by Google App Engine
This is Rietveld 408576698