Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 988403002: Revert of Re-enable Android profiling helper unittests (Closed)

Created:
5 years, 9 months ago by Sami
Modified:
5 years, 9 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Re-enable Android profiling helper unittests (patchset #1 id:1 of https://codereview.chromium.org/981293002/) Reason for revert: Still failing on the FYI bot: http://build.chromium.org/p/chromium.fyi/builders/Android%20Tests%20%28K%20N5%2C%20user%20build%29%28dbg%29 Original issue's description: > Re-enable Android profiling helper unittests > > These seem to be passing locally now. > > BUG=437081 > > Committed: https://crrev.com/49fdcead2be3fb974069fe8b70651e6b26ba9455 > Cr-Commit-Position: refs/heads/master@{#319471} TBR=primiano@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=437081 Committed: https://crrev.com/3b06d49c02b86e0a8fb28248c2f087f08edda70a Cr-Commit-Position: refs/heads/master@{#319633}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper_unittest.py View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sami
Created Revert of Re-enable Android profiling helper unittests
5 years, 9 months ago (2015-03-09 15:26:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988403002/1
5 years, 9 months ago (2015-03-09 15:27:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 15:27:49 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3b06d49c02b86e0a8fb28248c2f087f08edda70a Cr-Commit-Position: refs/heads/master@{#319633}
5 years, 9 months ago (2015-03-09 15:28:39 UTC) #4
Primiano Tucci (use gerrit)
5 years, 9 months ago (2015-03-09 15:32:13 UTC) #5
Message was sent while issue was closed.
compassionate LGTM

Powered by Google App Engine
This is Rietveld 408576698