Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 988393002: [Android] Pass --disable-location to provision_devices on ChromeDriver bots. (Closed)

Created:
5 years, 9 months ago by jbudorick
Modified:
5 years, 9 months ago
Reviewers:
klundberg, navabi1
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Pass --disable-location to provision_devices on ChromeDriver bots. BUG=460514 Committed: https://crrev.com/9669e5b823463915de6441b1343163facdd8efdd Cr-Commit-Position: refs/heads/master@{#319650}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M build/android/buildbot/bb_device_steps.py View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jbudorick
This should've been part of https://codereview.chromium.org/981783002/
5 years, 9 months ago (2015-03-09 14:53:45 UTC) #2
klundberg
lgtm
5 years, 9 months ago (2015-03-09 15:08:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988393002/1
5 years, 9 months ago (2015-03-09 15:09:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 16:29:13 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 16:29:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9669e5b823463915de6441b1343163facdd8efdd
Cr-Commit-Position: refs/heads/master@{#319650}

Powered by Google App Engine
This is Rietveld 408576698