Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 988383002: Upstream various ios/web utilities and helpers (Closed)

Created:
5 years, 9 months ago by stuartmorgan
Modified:
5 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@web-public-upstreaming
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream various ios/web utilities and helpers Upstreams miscellaneous helper classes and utility files that don't have other dependencies, and can thus be built and tested as-is. BUG=464810 Committed: https://crrev.com/fc8c88d3db12845eb0b6c31f754f8664ba6466fe Cr-Commit-Position: refs/heads/master@{#319706}

Patch Set 1 #

Total comments: 9
Unified diffs Side-by-side diffs Delta from patch set Stats (+1385 lines, -38 lines) Patch
A ios/web/crw_network_activity_indicator_manager.h View 1 chunk +67 lines, -0 lines 0 comments Download
A ios/web/crw_network_activity_indicator_manager.mm View 1 chunk +115 lines, -0 lines 4 comments Download
A ios/web/crw_network_activity_indicator_manager_unittest.mm View 1 chunk +154 lines, -0 lines 0 comments Download
A ios/web/history_state_util.h View 1 chunk +33 lines, -0 lines 1 comment Download
A ios/web/history_state_util.mm View 1 chunk +37 lines, -0 lines 0 comments Download
A ios/web/history_state_util_unittest.mm View 1 chunk +108 lines, -0 lines 2 comments Download
M ios/web/ios_web.gyp View 5 chunks +31 lines, -0 lines 0 comments Download
M ios/web/ios_web_unittests.gyp View 1 chunk +5 lines, -0 lines 0 comments Download
A ios/web/navigation/nscoder_util.h View 1 chunk +24 lines, -0 lines 0 comments Download
A ios/web/navigation/nscoder_util.mm View 1 chunk +25 lines, -0 lines 1 comment Download
A ios/web/navigation/nscoder_util_unittest.mm View 1 chunk +59 lines, -0 lines 0 comments Download
A ios/web/navigation/time_smoother.h View 1 chunk +32 lines, -0 lines 0 comments Download
A ios/web/navigation/time_smoother.cc View 1 chunk +25 lines, -0 lines 0 comments Download
A ios/web/net/request_group_util.h View 1 chunk +58 lines, -0 lines 0 comments Download
A ios/web/net/request_group_util.mm View 1 chunk +113 lines, -0 lines 0 comments Download
A ios/web/net/request_group_util_unittest.mm View 1 chunk +31 lines, -0 lines 0 comments Download
A ios/web/weak_nsobject_counter.h View 1 chunk +35 lines, -0 lines 0 comments Download
A ios/web/weak_nsobject_counter.mm View 1 chunk +83 lines, -0 lines 0 comments Download
A ios/web/weak_nsobject_counter_unittest.mm View 1 chunk +85 lines, -0 lines 0 comments Download
A ios/web/web_state/blocked_popup_info.h View 1 chunk +47 lines, -0 lines 0 comments Download
A ios/web/web_state/blocked_popup_info.mm View 1 chunk +39 lines, -0 lines 1 comment Download
A ios/web/web_state/crw_recurring_task_delegate.h View 1 chunk +16 lines, -0 lines 0 comments Download
M ios/web/web_state/js/crw_js_message_dynamic_manager.mm View 1 chunk +9 lines, -4 lines 0 comments Download
A ios/web/web_state/wk_web_view_ssl_error_util.h View 1 chunk +29 lines, -0 lines 0 comments Download
A ios/web/web_state/wk_web_view_ssl_error_util.mm View 1 chunk +96 lines, -0 lines 0 comments Download
M ios/web/web_view_util.h View 1 chunk +2 lines, -13 lines 0 comments Download
M ios/web/web_view_util.mm View 1 chunk +27 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
stuartmorgan
5 years, 9 months ago (2015-03-09 14:22:20 UTC) #2
Eugene But (OOO till 7-30)
lgtm with optional changes https://codereview.chromium.org/988383002/diff/1/ios/web/crw_network_activity_indicator_manager.mm File ios/web/crw_network_activity_indicator_manager.mm (right): https://codereview.chromium.org/988383002/diff/1/ios/web/crw_network_activity_indicator_manager.mm#newcode29 ios/web/crw_network_activity_indicator_manager.mm:29: - (id)init { Optional: s/id/instancetype ...
5 years, 9 months ago (2015-03-09 16:17:43 UTC) #3
stuartmorgan
To avoid merge conflicts, I'm going to land this as-is and let it get merged ...
5 years, 9 months ago (2015-03-09 18:41:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988383002/1
5 years, 9 months ago (2015-03-09 18:42:11 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-09 19:19:25 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 19:20:24 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/fc8c88d3db12845eb0b6c31f754f8664ba6466fe
Cr-Commit-Position: refs/heads/master@{#319706}

Powered by Google App Engine
This is Rietveld 408576698