Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Issue 988333003: [turbofan] Only reduce inline %DeoptimizeNow. (Closed)

Created:
5 years, 9 months ago by Michael Starzinger
Modified:
5 years, 9 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Only reduce inline %DeoptimizeNow. This makes sure only the %_DeoptimizeNow intrinsic is inlined, and not the %DeoptimizeNow one. It hence re-establishes the invariant that JSIntrinsicLowering only deals with inline intrinsics. R=jarin@chromium.org TEST=mjsunit/compiler/eager-deopt-simple Committed: https://crrev.com/dcb502a4eef665ee4409f8719080350943b08a73 Cr-Commit-Position: refs/heads/master@{#27070}

Patch Set 1 #

Patch Set 2 : Adapt linkage. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M src/compiler/js-intrinsic-lowering.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/compiler/linkage.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/compiler/eager-deopt-simple.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 9 months ago (2015-03-09 12:50:56 UTC) #1
Jarin
lgtm. Thanks!
5 years, 9 months ago (2015-03-09 13:01:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988333003/20001
5 years, 9 months ago (2015-03-09 13:03:59 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-09 13:20:21 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 13:20:37 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dcb502a4eef665ee4409f8719080350943b08a73
Cr-Commit-Position: refs/heads/master@{#27070}

Powered by Google App Engine
This is Rietveld 408576698