Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 98833002: Remove TreatNullAs=NullString for HTMLImageElement (Closed)

Created:
7 years ago by philipj_slow
Modified:
7 years ago
CC:
blink-reviews, adamk+blink_chromium.org, dglazkov+blink, arv+blink, Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Remove TreatNullAs=NullString for HTMLImageElement http://whatwg.org/html#htmlimageelement http://whatwg.org/html#HTMLImageElement-partial Take the opportunity to move standardized attributes into the main block and sort it. The border attribute has [TreatNullAs=EmptyString] in the spec. The tests for the updated properties pass in Firefox Nightly, IE11 Release Preview and Opera 12.16, with these exceptions: Firefox and Opera do not reflect lowsrc as a URL, and do not support srcset. IE throws an exception for align and does not support srcset. BUG=310298 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162990

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -26 lines) Patch
M LayoutTests/fast/dom/element-attribute-js-null.html View 1 chunk +9 lines, -7 lines 0 comments Download
M LayoutTests/fast/dom/element-attribute-js-null-expected.txt View 1 chunk +9 lines, -7 lines 0 comments Download
M Source/core/html/HTMLImageElement.idl View 1 chunk +12 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
philipj_slow
7 years ago (2013-12-02 13:18:02 UTC) #1
jochen (gone - plz use gerrit)
lgtm
7 years ago (2013-12-02 13:26:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/98833002/1
7 years ago (2013-12-02 13:27:23 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-02 14:21:49 UTC) #4
Message was sent while issue was closed.
Change committed as 162990

Powered by Google App Engine
This is Rietveld 408576698