Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 988323004: NaCl: disable unimplmented Mojo APIs. (Closed)

Created:
5 years, 9 months ago by Nick Bray (chromium)
Modified:
5 years, 9 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -166 lines) Patch
M mojo/public/platform/nacl/libmojo.cc View 1 chunk +1 line, -0 lines 0 comments Download
M nacl_bindings/mojo_syscall.cc View 3 chunks +12 lines, -166 lines 0 comments Download
M nacl_bindings_generator/generate_nacl_bindings.py View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Nick Bray (chromium)
5 years, 9 months ago (2015-03-09 19:50:26 UTC) #2
jamesr
lgtm
5 years, 9 months ago (2015-03-09 19:55:56 UTC) #3
Nick Bray (chromium)
5 years, 9 months ago (2015-03-09 20:00:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f2249c4ad872f90e40d83f1c86ba540b2a21b6c2.

Powered by Google App Engine
This is Rietveld 408576698