Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 988293004: Added the 'internal' flag for guestview event info. (Closed)

Created:
5 years, 9 months ago by paulmeyer
Modified:
5 years, 9 months ago
Reviewers:
Fady Samuel
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added the 'internal' flag for guestview event info. This flag will prevent an on* property from being created on the view's element. Committed: https://crrev.com/977466c71dd0860c0827209ef79ad0a46f0fbfda Cr-Commit-Position: refs/heads/master@{#319820}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -3 lines) Patch
M extensions/renderer/resources/guest_view/extension_view/extension_view_events.js View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/renderer/resources/guest_view/guest_view_events.js View 4 chunks +18 lines, -1 line 0 comments Download
M extensions/renderer/resources/guest_view/web_view/web_view_events.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
paulmeyer
+fsamuel@
5 years, 9 months ago (2015-03-09 22:57:08 UTC) #2
Fady Samuel
Thanks for catching this! lgtm.
5 years, 9 months ago (2015-03-09 23:00:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988293004/1
5 years, 9 months ago (2015-03-10 01:01:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-10 02:09:57 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 02:10:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/977466c71dd0860c0827209ef79ad0a46f0fbfda
Cr-Commit-Position: refs/heads/master@{#319820}

Powered by Google App Engine
This is Rietveld 408576698