Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 988283003: use a hash table for the function cache as blink is leaking functiontemplates (Closed)

Created:
5 years, 9 months ago by dcarney
Modified:
5 years, 9 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

use a hash table for the function cache as blink is leaking functiontemplates BUG= Committed: https://crrev.com/d7f25f557c20afe13a383a331208f4a8f05db3a5 Cr-Commit-Position: refs/heads/master@{#27066}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -35 lines) Patch
M src/api-natives.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/api-natives.cc View 2 chunks +21 lines, -25 lines 0 comments Download
M src/bootstrapper.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/contexts.h View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 1 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Toon Verwaest
arg, lgtm.
5 years, 9 months ago (2015-03-09 12:10:02 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988283003/20001
5 years, 9 months ago (2015-03-09 12:23:56 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-09 12:26:27 UTC) #5
commit-bot: I haz the power
5 years, 9 months ago (2015-03-09 12:26:34 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d7f25f557c20afe13a383a331208f4a8f05db3a5
Cr-Commit-Position: refs/heads/master@{#27066}

Powered by Google App Engine
This is Rietveld 408576698