Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2524)

Unified Diff: chrome/browser/resources/hotword/constants.js

Issue 988263002: Hotword: Make the new extension work with the NTP opt-in promo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/hotword/constants.js
diff --git a/chrome/browser/resources/hotword/constants.js b/chrome/browser/resources/hotword/constants.js
index 55a3d30dc7881976c9c33796433e77a468d6c3a4..af3b73711eb4ef7867835cc0d7b7565b05ddec43 100644
--- a/chrome/browser/resources/hotword/constants.js
+++ b/chrome/browser/resources/hotword/constants.js
@@ -141,8 +141,8 @@ var CommandToPage = {
};
/**
- * Messages sent from the Google page to the injected scripts
- * and then passed to the extension.
+ * Messages sent from the Google page to the extension or to the
+ * injected scripts and then passed to the extension.
Anand Mistry (off Chromium) 2015/03/10 02:47:28 s/scripts/script while you're here
kcarattini 2015/03/10 04:34:05 Done.
* @enum {string}
*/
var CommandFromPage = {
@@ -155,7 +155,14 @@ var CommandFromPage = {
CLICKED_RESUME: 'hcc',
CLICKED_RESTART: 'hcr',
CLICKED_DEBUG: 'hcd',
- WAKE_UP_HELPER: 'wuh'
+ WAKE_UP_HELPER: 'wuh',
+ // Command specifically for the opt-in promo below this line.
+ // User has explicitly clicked 'no'.
+ CLICKED_NO_OPTIN: 'hcno',
+ // User has opted in.
+ CLICKED_OPTIN: 'hco',
+ // User clicked on the microphone.
+ PAGE_WAKEUP: 'wu'
};
/**
« no previous file with comments | « no previous file | chrome/browser/resources/hotword/manifest.json » ('j') | chrome/browser/resources/hotword/manifest.json » ('J')

Powered by Google App Engine
This is Rietveld 408576698