Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 988263002: Hotword: Make the new extension work with the NTP opt-in promo. (Closed)

Created:
5 years, 9 months ago by kcarattini
Modified:
5 years, 9 months ago
CC:
chromium-reviews, rlp+watch_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Hotword: Make the new extension work with the NTP opt-in promo. BUG=436681 Committed: https://crrev.com/69cfa7bbd88391cef0ad02f4e95697c674404e77 Cr-Commit-Position: refs/heads/master@{#319844}

Patch Set 1 #

Total comments: 14

Patch Set 2 : Review Comments #

Patch Set 3 : Review Commetns #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -5 lines) Patch
M chrome/browser/resources/hotword/constants.js View 1 2 chunks +10 lines, -3 lines 0 comments Download
M chrome/browser/resources/hotword/manifest.json View 1 1 chunk +22 lines, -0 lines 0 comments Download
M chrome/browser/resources/hotword/page_audio_manager.js View 1 2 7 chunks +75 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (2 generated)
kcarattini
5 years, 9 months ago (2015-03-09 05:21:50 UTC) #2
Anand Mistry (off Chromium)
https://codereview.chromium.org/988263002/diff/1/chrome/browser/resources/hotword/constants.js File chrome/browser/resources/hotword/constants.js (right): https://codereview.chromium.org/988263002/diff/1/chrome/browser/resources/hotword/constants.js#newcode145 chrome/browser/resources/hotword/constants.js:145: * injected scripts and then passed to the extension. ...
5 years, 9 months ago (2015-03-10 02:47:29 UTC) #3
kcarattini
https://codereview.chromium.org/988263002/diff/1/chrome/browser/resources/hotword/constants.js File chrome/browser/resources/hotword/constants.js (right): https://codereview.chromium.org/988263002/diff/1/chrome/browser/resources/hotword/constants.js#newcode145 chrome/browser/resources/hotword/constants.js:145: * injected scripts and then passed to the extension. ...
5 years, 9 months ago (2015-03-10 04:34:05 UTC) #4
Anand Mistry (off Chromium)
https://codereview.chromium.org/988263002/diff/1/chrome/browser/resources/hotword/page_audio_manager.js File chrome/browser/resources/hotword/page_audio_manager.js (right): https://codereview.chromium.org/988263002/diff/1/chrome/browser/resources/hotword/page_audio_manager.js#newcode429 chrome/browser/resources/hotword/page_audio_manager.js:429: chrome.hotwordPrivate && chrome.hotwordPrivate.getStatus) { On 2015/03/10 04:34:05, kcarattini wrote: ...
5 years, 9 months ago (2015-03-10 04:40:54 UTC) #5
kcarattini
https://codereview.chromium.org/988263002/diff/1/chrome/browser/resources/hotword/page_audio_manager.js File chrome/browser/resources/hotword/page_audio_manager.js (right): https://codereview.chromium.org/988263002/diff/1/chrome/browser/resources/hotword/page_audio_manager.js#newcode429 chrome/browser/resources/hotword/page_audio_manager.js:429: chrome.hotwordPrivate && chrome.hotwordPrivate.getStatus) { On 2015/03/10 04:40:54, Anand Mistry ...
5 years, 9 months ago (2015-03-10 04:50:58 UTC) #6
Anand Mistry (off Chromium)
lgtm
5 years, 9 months ago (2015-03-10 05:58:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988263002/40001
5 years, 9 months ago (2015-03-10 06:08:14 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-10 06:51:00 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-10 06:51:36 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/69cfa7bbd88391cef0ad02f4e95697c674404e77
Cr-Commit-Position: refs/heads/master@{#319844}

Powered by Google App Engine
This is Rietveld 408576698