Supporting blob urls for html5 media

Supporting blob urls for html5 media

Android mediaplayer won't be able to handle blob urls.
After xhr requests creates a temporary file with blob url, we need to pass the file path to the media player so it can play the file.

TBR=tedchoc
BUG=253465
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245108

[qinmin, 2013-12-13 23:46:02]

PTAL

[scherkus (not reviewing), 2014-01-07 19:27:51]

looks like this fell off my radar -- did you still need this reviewed?

[qinmin, 2014-01-07 20:36:02]

On 2014/01/07 19:27:51, scherkus wrote:
> looks like this fell off my radar -- did you still need this reviewed?

yes, please. Thanks a lot

[qinmin, 2014-01-10 17:04:47]

ping, scherkus@, would you please take a look? thanks

[scherkus (not reviewing), 2014-01-10 17:15:13]

arg .. sorry qinmin@ I got too busy again :(

xhwang@ can you take a look?

[xhwang, 2014-01-14 17:57:39]

lgtm % comments

https://codereview.chromium.org/98823003/diff/20001/content/browser/media/and...
File content/browser/media/android/media_resource_getter_impl.cc (right):

https://codereview.chromium.org/98823003/diff/20001/content/browser/media/and...
content/browser/media/android/media_resource_getter_impl.cc:51: DCHECK_EQ(1u,
items.size());
The blob data comes from user. So user can easily trigger this DCHECK which is
not desired. How about changing this DCHECK to a log/warning?

https://codereview.chromium.org/98823003/diff/20001/content/browser/media/and...
content/browser/media/android/media_resource_getter_impl.cc:52:
items[0].path().value();
This doesn't seem to do anything.. remove?

https://codereview.chromium.org/98823003/diff/20001/media/base/android/media_...
File media/base/android/media_player_bridge.cc (right):

https://codereview.chromium.org/98823003/diff/20001/media/base/android/media_...
media/base/android/media_player_bridge.cc:24: static const char kBlobScheme[] =
"blob";
nit: "static" isn't necessary. Global const variables are static by default.

[qinmin, 2014-01-14 21:48:32]

https://codereview.chromium.org/98823003/diff/20001/content/browser/media/and...
File content/browser/media/android/media_resource_getter_impl.cc (right):

https://codereview.chromium.org/98823003/diff/20001/content/browser/media/and...
content/browser/media/android/media_resource_getter_impl.cc:51: DCHECK_EQ(1u,
items.size());
On 2014/01/14 17:57:40, xhwang wrote:
> The blob data comes from user. So user can easily trigger this DCHECK which is
> not desired. How about changing this DCHECK to a log/warning?

Done.

https://codereview.chromium.org/98823003/diff/20001/content/browser/media/and...
content/browser/media/android/media_resource_getter_impl.cc:52:
items[0].path().value();
On 2014/01/14 17:57:40, xhwang wrote:
> This doesn't seem to do anything.. remove?

Done.

https://codereview.chromium.org/98823003/diff/20001/media/base/android/media_...
File media/base/android/media_player_bridge.cc (right):

https://codereview.chromium.org/98823003/diff/20001/media/base/android/media_...
media/base/android/media_player_bridge.cc:24: static const char kBlobScheme[] =
"blob";
On 2014/01/14 17:57:40, xhwang wrote:
> nit: "static" isn't necessary. Global const variables are static by default.
> 

Done.

[commit-bot: I haz the power, 2014-01-14 22:30:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/98823003/110001

[commit-bot: I haz the power, 2014-01-15 00:23:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/98823003/110001

[commit-bot: I haz the power, 2014-01-15 14:06:47]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2014-01-15 19:15:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/98823003/110001

[commit-bot: I haz the power, 2014-01-16 03:35:42]

Commit queue rejected this change because the description was changed
between the time the change entered the commit queue and the time it
was ready to commit. You can safely check the commit box again.

[commit-bot: I haz the power, 2014-01-16 04:05:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/qinmin@chromium.org/98823003/110001

[commit-bot: I haz the power, 2014-01-16 04:32:50]

Change committed as 245108