Make SSLClientSocketFalseStartTest.NoSessionResumptionBeforeFinish not a no-op.

net/socket/ssl_client_socket_unittest.cc

Index: net/socket/ssl_client_socket_unittest.cc
diff --git a/net/socket/ssl_client_socket_unittest.cc b/net/socket/ssl_client_socket_unittest.cc
index 2390bd59ff68a36c2a2a119b4f44aa828156381b..f48e1c77a2cd8dee1149d88175ac371660835f36 100644
--- a/net/socket/ssl_client_socket_unittest.cc
+++ b/net/socket/ssl_client_socket_unittest.cc
@@ -3178,6 +3178,14 @@ TEST_F(SSLClientSocketFalseStartTest, NoSessionResumptionBeforeFinish) {
   // still completes.
   EXPECT_EQ(OK, callback.WaitForResult());
 
+  // Leave the server Finished blocked, but wait for it to arrive. This ensures
+  // the server has completed the handshake and added the session to its session
+  // cache.

[Ryan Sleevi, 2015/03/09 21:56:12]

Suggested reword:

// Continue to block the client (|sock1|) from processing the Finished
// message, but allow it to arrive on the socket. This ensures that
// from the server's point of view, it has completed the handshake and
// added the session to its session cache.
// The actual read on |sock1| will not complete until the Finished message
// is processed; however, pump the underlying transport so that it is
// read from the socket. This still has the potential to race, but is
// generally unlikely due to socket buffer sizes.

[davidben, 2015/03/09 22:01:13]

Done.

+  scoped_refptr<IOBuffer> buf(new IOBuffer(4096));
+  int rv = sock1->Read(buf.get(), 4096, callback.callback());
+  EXPECT_EQ(ERR_IO_PENDING, rv);
+  raw_transport1->WaitForReadResult();
+
   // Drop the old socket. This is needed because the Python test server can't
   // service two sockets in parallel.
   sock1.reset();