Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 988183003: Build changes for android on arm (Closed)

Created:
5 years, 9 months ago by sky
Modified:
5 years, 9 months ago
Reviewers:
brettw
CC:
chromium-reviews, jshin+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Build changes for android on arm V8 wants to key off information about arm regardless of whether arm is the host/target. Added a couple of flags that icu want to set when building for arm too. These changes mirror the gyp side. R=brettw@chromium.org BUG=465456

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -34 lines) Patch
M build/config/arm.gni View 2 chunks +3 lines, -2 lines 1 comment Download
M build/module_args/v8.gni View 1 chunk +4 lines, -0 lines 0 comments Download
M build/secondary/third_party/icu/BUILD.gn View 12 chunks +49 lines, -32 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
sky
https://codereview.chromium.org/988183003/diff/1/build/secondary/third_party/icu/BUILD.gn File build/secondary/third_party/icu/BUILD.gn (right): https://codereview.chromium.org/988183003/diff/1/build/secondary/third_party/icu/BUILD.gn#newcode94 build/secondary/third_party/icu/BUILD.gn:94: "source/i18n/coll.cpp", I ran gn format on this and it ...
5 years, 9 months ago (2015-03-09 20:18:42 UTC) #1
sky
I can't actually land this until I land https://codereview.chromium.org/991023002 and https://codereview.chromium.org/984353002/ . The latter I ...
5 years, 9 months ago (2015-03-09 21:53:55 UTC) #2
brettw
https://codereview.chromium.org/988183003/diff/1/build/config/arm.gni File build/config/arm.gni (right): https://codereview.chromium.org/988183003/diff/1/build/config/arm.gni#newcode5 build/config/arm.gni:5: # Some components need arm settings for target_cpu too. ...
5 years, 9 months ago (2015-03-16 17:16:36 UTC) #3
sky
5 years, 9 months ago (2015-03-17 19:02:49 UTC) #4
This patch isn't needed, closing out.

Powered by Google App Engine
This is Rietveld 408576698