Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Unified Diff: Source/core/html/HTMLCanvasElement.idl

Issue 988173002: Sync HTML element interfaces C-D with the spec (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/html/HTMLContentElement.idl » ('j') | Source/core/html/HTMLDivElement.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/HTMLCanvasElement.idl
diff --git a/Source/core/html/HTMLCanvasElement.idl b/Source/core/html/HTMLCanvasElement.idl
index 5f2ee7c88105497ec14666243e705cdfa4aa9bc2..25e95d7a7ef947231b88b5a120bd7ab22a02fe70 100644
--- a/Source/core/html/HTMLCanvasElement.idl
+++ b/Source/core/html/HTMLCanvasElement.idl
@@ -24,16 +24,16 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
+// https://html.spec.whatwg.org/#htmlcanvaselement
+
typedef (CanvasRenderingContext2D or WebGLRenderingContext) RenderingContext;
interface HTMLCanvasElement : HTMLElement {
-
+ // FIXME: width and height should be unsigned long.
attribute long width;
attribute long height;
- [RaisesException] DOMString toDataURL(optional DOMString? type = null, optional any arguments);
-
- // Note: this differs deliberately from the specified Web IDL for this function:
+ // FIXME: this differs deliberately from the specified Web IDL for this function:
// RenderingContext? getContext(DOMString contextId, any... arguments);
// in order to eliminate the custom binding. It is functionally equivalent.
//
@@ -47,4 +47,8 @@ interface HTMLCanvasElement : HTMLElement {
// handled differently the return type could be changed to "RenderingContext?"
// and the [CallWith=ScriptState] extended attribute removed.
[CallWith=ScriptState] any getContext([Default=Undefined] optional DOMString contextId, [PermissiveDictionaryConversion] optional CanvasContextCreationAttributes attributes);
+
+ // FIXME: type should not be nullable or have a default value and the
+ // trailing arguments should be variadic.
Jens Widell 2015/03/08 09:36:46 The variadic bit is something we might not want to
philipj_slow 2015/03/08 14:28:58 Yes, and I think this is a bit weird in the spec,
Jens Widell 2015/03/08 15:56:28 "... since only the first argument is used in our
philipj_slow 2015/03/09 10:43:25 I agree, how's the new comment?
+ [RaisesException] DOMString toDataURL(optional DOMString? type = null, optional any arguments);
};
« no previous file with comments | « no previous file | Source/core/html/HTMLContentElement.idl » ('j') | Source/core/html/HTMLDivElement.idl » ('J')

Powered by Google App Engine
This is Rietveld 408576698