Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 988113002: Revert of base: Remove operator& from ScopedAuthorizationRef. (Closed)

Created:
5 years, 9 months ago by Avi (use Gerrit)
Modified:
5 years, 9 months ago
Reviewers:
danakj, Nico
CC:
chromium-reviews, erikwright+watch_chromium.org, piman, Mark Mentovai
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of base: Remove operator& from ScopedAuthorizationRef. (patchset #1 id:1 of https://codereview.chromium.org/986563003/) Reason for revert: Breaks the official Mac bot: ../../remoting/host/installer/mac/uninstaller/remoting_uninstaller.mm:155:21:error: no matching function for call to 'AuthorizationCreate' OSStatus status = AuthorizationCreate(nullptr, kAuthorizationEmptyEnvironment, ^~~~~~~~~~~~~~~~~~~ /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk/System/Library/Frameworks/Security.framework/Headers/Authorization.h:253:10: note: candidate function not viable: no known conversion from 'base::mac::ScopedAuthorizationRef *' to 'AuthorizationRef *' (aka 'const AuthorizationOpaqueRef **') for 4th argument OSStatus AuthorizationCreate(const AuthorizationRights *rights, Original issue's description: > base: Remove operator& from ScopedAuthorizationRef. > > The operator& is dangerous and makes it unclear what you are doing. > Replace it with a get_pointer() method. > > R=Nico > BUG=464816 > > Committed: https://crrev.com/845755856c54aabac7022ee373618468b92f2e61 > Cr-Commit-Position: refs/heads/master@{#319565} TBR=thakis@chromium.org,danakj@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=464816 Committed: https://crrev.com/40ef92499a1c5983d755ca23dd0cfaf7529d0fc2 Cr-Commit-Position: refs/heads/master@{#319570}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M base/mac/authorization_util.mm View 1 chunk +3 lines, -2 lines 0 comments Download
M base/mac/scoped_authorizationref.h View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Avi (use Gerrit)
Created Revert of base: Remove operator& from ScopedAuthorizationRef.
5 years, 9 months ago (2015-03-08 02:35:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988113002/1
5 years, 9 months ago (2015-03-08 02:36:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-08 02:36:56 UTC) #3
commit-bot: I haz the power
5 years, 9 months ago (2015-03-08 02:37:30 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/40ef92499a1c5983d755ca23dd0cfaf7529d0fc2
Cr-Commit-Position: refs/heads/master@{#319570}

Powered by Google App Engine
This is Rietveld 408576698