Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: client/crash_report_database_win.cc

Issue 988063003: Define the Settings interface for a CrashReportDatabase and provide a Mac implementation. (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Drop plist, use binary Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: client/crash_report_database_win.cc
diff --git a/client/crash_report_database_win.cc b/client/crash_report_database_win.cc
index 630adb1036574dd6762d5987c282faab03357d10..34ae79b3d64b0028f584a0894965b5e53a83347e 100644
--- a/client/crash_report_database_win.cc
+++ b/client/crash_report_database_win.cc
@@ -524,6 +524,7 @@ class CrashReportDatabaseWin : public CrashReportDatabase {
bool Initialize();
// CrashReportDatabase:
+ Settings* GetSettings() override;
OperationStatus PrepareNewCrashReport(NewReport** report) override;
OperationStatus FinishedWritingCrashReport(NewReport* report,
UUID* uuid) override;
@@ -567,6 +568,10 @@ bool CrashReportDatabaseWin::Initialize() {
return true;
}
+Settings* CrashReportDatabaseWin::GetSettings() {
+ return nullptr;
Mark Mentovai 2015/03/09 19:12:35 Put a comment referencing bug 13 and call NOTREACH
Robert Sesek 2015/03/09 21:16:27 Done.
+}
+
OperationStatus CrashReportDatabaseWin::PrepareNewCrashReport(
NewReport** report) {
::UUID system_uuid;

Powered by Google App Engine
This is Rietveld 408576698