Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: client/client.gyp

Issue 988063003: Define the Settings interface for a CrashReportDatabase and provide a Mac implementation. (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Drop plist, use binary Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | client/crash_report_database.h » ('j') | client/crash_report_database_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/client.gyp
diff --git a/client/client.gyp b/client/client.gyp
index c8895563f80d0a2f563737eaacf02ec0ee84cb74..fca3f26e31c4f18fccbc9b14dcfe8a281b8b0553 100644
--- a/client/client.gyp
+++ b/client/client.gyp
@@ -36,6 +36,8 @@
'crashpad_client_mac.cc',
'crashpad_info.cc',
'crashpad_info.h',
+ 'settings.cc',
+ 'settings.h',
'simple_string_dictionary.cc',
'simple_string_dictionary.h',
'simulate_crash.h',
@@ -49,6 +51,10 @@
'-lrpcrt4.lib',
],
},
+ 'sources!': [
+ # Port to Win: https://code.google.com/p/crashpad/issues/detail?id=13
Mark Mentovai 2015/03/09 19:12:35 80. Same on line 86.
Robert Sesek 2015/03/09 21:16:26 Done.
+ 'settings.cc',
+ ],
}],
],
},
@@ -70,9 +76,18 @@
'sources': [
'capture_context_mac_test.cc',
'crash_report_database_test.cc',
+ 'settings_test.cc',
'simple_string_dictionary_test.cc',
'simulate_crash_mac_test.cc',
],
+ 'conditions': [
+ ['OS=="win"', {
+ 'sources!': [
+ # Port to Win: https://code.google.com/p/crashpad/issues/detail?id=13
+ 'settings_test.cc',
+ ],
+ }],
+ ],
},
],
}
« no previous file with comments | « no previous file | client/crash_report_database.h » ('j') | client/crash_report_database_mac.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698