Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: client/crash_report_database_win.cc

Issue 988063003: Define the Settings interface for a CrashReportDatabase and provide a Mac implementation. (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: For landing Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/crash_report_database_mac.mm ('k') | client/settings.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: client/crash_report_database_win.cc
diff --git a/client/crash_report_database_win.cc b/client/crash_report_database_win.cc
index 84ed6e2291a8bea223f3629b1f73a6620c5c7abd..a80046c16682eb330aa35210ac0651b8d4dff116 100644
--- a/client/crash_report_database_win.cc
+++ b/client/crash_report_database_win.cc
@@ -524,6 +524,7 @@ class CrashReportDatabaseWin : public CrashReportDatabase {
bool Initialize();
// CrashReportDatabase:
+ Settings* GetSettings() override;
OperationStatus PrepareNewCrashReport(NewReport** report) override;
OperationStatus FinishedWritingCrashReport(NewReport* report,
UUID* uuid) override;
@@ -565,6 +566,12 @@ bool CrashReportDatabaseWin::Initialize() {
return true;
}
+Settings* CrashReportDatabaseWin::GetSettings() {
+ // Port to Win https://code.google.com/p/crashpad/issues/detail?id=13.
+ NOTREACHED();
+ return nullptr;
+}
+
OperationStatus CrashReportDatabaseWin::PrepareNewCrashReport(
NewReport** report) {
::UUID system_uuid;
« no previous file with comments | « client/crash_report_database_mac.mm ('k') | client/settings.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698