Define the Settings interface for a CrashReportDatabase and provide a Mac implementation.

client/settings_test.cc

Index: client/settings_test.cc
diff --git a/client/settings_test.cc b/client/settings_test.cc
new file mode 100644
index 0000000000000000000000000000000000000000..39bdeddad79e9b700690599251cd94595b372b94
--- /dev/null
+++ b/client/settings_test.cc
@@ -0,0 +1,83 @@
+// Copyright 2015 The Crashpad Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "client/settings.h"
+
+#include "client/crash_report_database.h"
+#include "gtest/gtest.h"
+#include "util/test/scoped_temp_dir.h"
+
+namespace crashpad {
+namespace test {
+

[Mark Mentovai, 2015/03/08 05:21:56]

Inner unnamed namespace, too, like all of the other tests.

[Robert Sesek, 2015/03/08 22:15:36]

Done.

+class SettingsTest : public testing::Test {
+ public:
+  SettingsTest() {}
+
+  Settings* settings() { return db_->GetSettings(); }
+
+ protected:
+  // testing::Test:
+  void SetUp() override {
+    ReopenDatabase();
+  }
+
+  void ReopenDatabase() {
+    db_.reset();
+    db_ = CrashReportDatabase::Initialize(temp_dir_.path());
+    ASSERT_TRUE(db_);
+  }
+
+ private:

[Mark Mentovai, 2015/03/08 05:21:56]

DISALLOW_COPY_AND_ASSIGN

[Robert Sesek, 2015/03/08 22:15:36]

Done.

+  ScopedTempDir temp_dir_;
+  scoped_ptr<CrashReportDatabase> db_;
+};
+
+TEST_F(SettingsTest, ClientID) {
+  std::string client_id;
+  EXPECT_TRUE(settings()->GetClientID(&client_id));
+  EXPECT_FALSE(client_id.empty());
+
+  ReopenDatabase();
+
+  std::string actual;
+  EXPECT_TRUE(settings()->GetClientID(&actual));
+  EXPECT_EQ(client_id, actual);
+}
+
+TEST_F(SettingsTest, UploadsEnabled) {
+  bool enabled = false;
+  EXPECT_FALSE(settings()->GetUploadsEnabled(&enabled));
+
+  EXPECT_TRUE(settings()->SetUploadsEnabled(true));
+  EXPECT_TRUE(settings()->GetUploadsEnabled(&enabled));
+  EXPECT_TRUE(enabled);
+
+  EXPECT_TRUE(settings()->SetUploadsEnabled(false));
+  EXPECT_TRUE(settings()->GetUploadsEnabled(&enabled));
+  EXPECT_FALSE(enabled);
+}
+
+TEST_F(SettingsTest, LastUploadAttemptTime) {
+  time_t actual = -1;
+  EXPECT_FALSE(settings()->GetLastUploadAttemptTime(&actual));
+
+  time_t expected = time(nullptr);
+  EXPECT_TRUE(settings()->SetLastUploadAttemptTime(expected));
+  EXPECT_TRUE(settings()->GetLastUploadAttemptTime(&actual));
+  EXPECT_EQ(expected, actual);
+}
+
+}  // namespace test
+}  // namespace crashpad