Define the Settings interface for a CrashReportDatabase and provide a Mac implementation.

client/crash_report_database_mac.mm

 // Copyright 2015 The Crashpad Authors. All rights reserved.
 //
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
 //
 //     http://www.apache.org/licenses/LICENSE-2.0
 //
 // Unless required by applicable law or agreed to in writing, software
 // distributed under the License is distributed on an "AS IS" BASIS,
@@ skipping 11 matching lines @@
 #include <sys/types.h>
 #include <unistd.h>
 #include <uuid/uuid.h>
 
 #include "base/logging.h"
 #include "base/posix/eintr_wrapper.h"
 #include "base/scoped_generic.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/sys_string_conversions.h"
+#include "client/settings_mac.h"
 #include "util/file/file_io.h"
 #include "util/mac/xattr.h"
 
 namespace crashpad {
 
 namespace {
 
 const char kDatabaseDirectoryName[] = "Crashpad";
 
 const char kWriteDirectory[] = "new";
 const char kUploadPendingDirectory[] = "pending";
 const char kCompletedDirectory[] = "completed";
 
+const char kSettings[] = "settings.plist";
+
 const char* const kReportDirectories[] = {
   kWriteDirectory,
   kUploadPendingDirectory,
   kCompletedDirectory,
 };
 
 const char kCrashReportFileExtension[] = "dmp";
 
 const char kXattrUUID[] = "uuid";
 const char kXattrCollectorID[] = "id";
@@ skipping 44 matching lines @@
 //! extended attribute operations. The lock should be obtained using
 //! ObtainReportLock().
 class CrashReportDatabaseMac : public CrashReportDatabase {
  public:
   explicit CrashReportDatabaseMac(const base::FilePath& path);
   virtual ~CrashReportDatabaseMac();
 
   bool Initialize();
 
   // CrashReportDatabase:
+  Settings* GetSettings() override;
   OperationStatus PrepareNewCrashReport(NewReport** report) override;
   OperationStatus FinishedWritingCrashReport(NewReport* report,
                                              UUID* uuid) override;
   OperationStatus ErrorWritingCrashReport(NewReport* report) override;
   OperationStatus LookUpCrashReport(const UUID& uuid,
                                     Report* report) override;
   OperationStatus GetPendingReports(
       std::vector<const Report>* reports) override;
   OperationStatus GetCompletedReports(
       std::vector<const Report>* reports) override;
@@ skipping 60 matching lines @@
 
 
   //! \brief Creates a database xattr name from the short constant name.
   //!
   //! \param[in] name The short name of the extended attribute.
   //!
   //! \return The long name of the extended attribute.
   static std::string XattrName(const base::StringPiece& name);
 
   base::FilePath base_dir_;
+  internal::SettingsMac settings_;
 
   DISALLOW_COPY_AND_ASSIGN(CrashReportDatabaseMac);
 };
 
 CrashReportDatabaseMac::CrashReportDatabaseMac(const base::FilePath& path)
-    : CrashReportDatabase(), base_dir_(path) {
+    : CrashReportDatabase(),
+      base_dir_(path),
+      settings_(base_dir_.Append(kSettings)) {
 }
 
 CrashReportDatabaseMac::~CrashReportDatabaseMac() {}
 
 bool CrashReportDatabaseMac::Initialize() {
   // Check if the database already exists.
   if (!CreateOrEnsureDirectoryExists(base_dir_))
     return false;
 
   // Create the three processing directories for the database.
   for (size_t i = 0; i < arraysize(kReportDirectories); ++i) {
     if (!CreateOrEnsureDirectoryExists(base_dir_.Append(kReportDirectories[i])))
       return false;
   }
 
+  if (!settings_.Initialize())
+    return false;
+
   // Write an xattr as the last step, to ensure the filesystem has support for
   // them. This attribute will never be read.
   return WriteXattrBool(base_dir_, XattrName(kXattrDatabaseInitialized), true);
 }
 
+Settings* CrashReportDatabaseMac::GetSettings() {
+  return &settings_;
+}
+
 CrashReportDatabase::OperationStatus
 CrashReportDatabaseMac::PrepareNewCrashReport(NewReport** out_report) {
   uuid_t uuid_gen;
   uuid_generate(uuid_gen);
   UUID uuid(uuid_gen);
 
   scoped_ptr<NewReport> report(new NewReport());
 
   report->path =
       base_dir_.Append(kWriteDirectory)
@@ skipping 278 matching lines @@
   return true;
 }
 
 // static
 CrashReportDatabase::OperationStatus CrashReportDatabaseMac::ReportsInDirectory(
     const base::FilePath& path,
     std::vector<const CrashReportDatabase::Report>* reports) {
   DCHECK(reports->empty());
 
   NSError* error = nil;
   NSArray* paths = [[NSFileManager defaultManager]

[Mark Mentovai, 2015/03/09 14:01:23]

This talk of the autorelease pool in Settings prompted me to check the database
too:

An autorelease pool is needed here (a separate change for that would be OK).

       contentsOfDirectoryAtPath:base::SysUTF8ToNSString(path.value())
                           error:&error];
   if (error) {
     LOG(ERROR) << "Failed to enumerate reports in directory " << path.value()
                << ": " << [[error description] UTF8String];
     return kFileSystemError;
   }
 
   reports->reserve([paths count]);
   for (NSString* entry in paths) {
@@ skipping 26 matching lines @@
     const base::FilePath& path) {
   scoped_ptr<CrashReportDatabaseMac> database_mac(
       new CrashReportDatabaseMac(path.Append(kDatabaseDirectoryName)));
   if (!database_mac->Initialize())
     database_mac.reset();
 
   return scoped_ptr<CrashReportDatabase>(database_mac.release());
 }
 
 }  // namespace crashpad