Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 988053002: gpu: Convert egl_native target to GN build. (Closed)

Created:
5 years, 9 months ago by tfarina
Modified:
5 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, piman+watch_chromium.org, brettw, piman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gpu: Convert egl_native target to GN build. Tested with the following command lines: $ gn gen out-gn $ ninja -C out-gn egl $ gn check out-gn //gpu/gles2_conform_support/egl/* BUG=None TEST=see above R=dpranke@chromium.org TBR=piman@chromium.org Committed: https://crrev.com/c6d331fdd10a78141791ef9b41abb06802db015e Cr-Commit-Position: refs/heads/master@{#319591}

Patch Set 1 #

Total comments: 2

Patch Set 2 : self review #

Total comments: 2

Patch Set 3 : source_set #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
A gpu/gles2_conform_support/egl/BUILD.gn View 1 2 1 chunk +36 lines, -0 lines 0 comments Download
M gpu/gles2_conform_support/gles2_conform_support.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
tfarina
https://codereview.chromium.org/988053002/diff/1/BUILD.gn File BUILD.gn (right): https://codereview.chromium.org/988053002/diff/1/BUILD.gn#newcode58 BUILD.gn:58: "//gpu/gles2_conform_support/egl", I just added this line here to test ...
5 years, 9 months ago (2015-03-07 18:13:47 UTC) #1
tfarina
https://codereview.chromium.org/988053002/diff/1/gpu/gles2_conform_support/egl/BUILD.gn File gpu/gles2_conform_support/egl/BUILD.gn (right): https://codereview.chromium.org/988053002/diff/1/gpu/gles2_conform_support/egl/BUILD.gn#newcode1 gpu/gles2_conform_support/egl/BUILD.gn:1: # Copyright 2014 The Chromium Authors. All rights reserved. ...
5 years, 9 months ago (2015-03-07 18:14:23 UTC) #2
tfarina
Patch set 2 uploaded! PTAL!
5 years, 9 months ago (2015-03-07 22:09:41 UTC) #3
Dirk Pranke
lgtm https://codereview.chromium.org/988053002/diff/20001/gpu/gles2_conform_support/egl/BUILD.gn File gpu/gles2_conform_support/egl/BUILD.gn (right): https://codereview.chromium.org/988053002/diff/20001/gpu/gles2_conform_support/egl/BUILD.gn#newcode6 gpu/gles2_conform_support/egl/BUILD.gn:6: static_library("egl") { It might be worth making this ...
5 years, 9 months ago (2015-03-08 01:50:55 UTC) #4
tfarina
https://codereview.chromium.org/988053002/diff/20001/gpu/gles2_conform_support/egl/BUILD.gn File gpu/gles2_conform_support/egl/BUILD.gn (right): https://codereview.chromium.org/988053002/diff/20001/gpu/gles2_conform_support/egl/BUILD.gn#newcode6 gpu/gles2_conform_support/egl/BUILD.gn:6: static_library("egl") { On 2015/03/08 01:50:55, Dirk Pranke wrote: > ...
5 years, 9 months ago (2015-03-08 11:29:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/988053002/40001
5 years, 9 months ago (2015-03-08 11:31:03 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-08 12:02:31 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-08 12:03:00 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c6d331fdd10a78141791ef9b41abb06802db015e
Cr-Commit-Position: refs/heads/master@{#319591}

Powered by Google App Engine
This is Rietveld 408576698